feat(logger): add shared logger package with pino integration (#37)

* feat(logger): add @pleaseai/logger package with pino integration

Create new logger package for structured logging across the monorepo:
- pino-based implementation for high performance
- Auto-detects pretty printing via NODE_ENV
- Redacts sensitive fields (password, secret, token, apiKey, etc.)
- All output to stderr (stdout reserved for protocol data)
- Typed API: createLogger(name) factory and default logger singleton

Issue: #36

* feat(logger): integrate logger across all packages

Replace console.* calls with structured pino logging in:
- code: CLI error handling with fatal log
- code-format: Format initialization and formatting operations
- code-lsp: LSP server lifecycle, diagnostics, and operations
- dora: MCP server, port discovery, and ast-grep provider

All packages now use @pleaseai/logger for consistent structured logging.

* fix(logger): add error notification in fallback and comprehensive tests

- Add console.error notification for unexpected errors during pino-pretty initialization
- Distinguish expected "module not found" from unexpected errors
- Add 22 new tests for redaction functionality covering all sensitive fields
- Add tests for environment configuration (LOG_LEVEL, NODE_ENV)
- Add tests for child logger context propagation

Author: amondnet

bun.lock

@@ -32,7 +32,8 @@
   },
   "dependencies": {
     "@pleaseai/code-format": "workspace:*",
-    "@pleaseai/code-lsp": "workspace:*"
+    "@pleaseai/code-lsp": "workspace:*",
+    "@pleaseai/logger": "workspace:*"
   },
   "devDependencies": {
     "@types/bun": "latest",

packages/code/package.json

@@ -15,10 +15,13 @@
 import { Buffer } from 'node:buffer'
 import process from 'node:process'
 import { Format } from '@pleaseai/code-format'
+import { createLogger } from '@pleaseai/logger'
 import pkg from '../package.json'
 import { runLSPDiagnostics } from './hooks/lsp'
 import { parseArgs } from './utils'
 
+const log = createLogger('code')
+
 const VERSION = pkg.version
 
 interface HookInput {
@@ -203,6 +206,6 @@ async function main(): Promise<void> {
 }
 
 main().catch((error) => {
-  console.error('[code] Error:', error)
+  log.fatal({ err: error }, 'Unhandled error')
   process.exit(1)
 })

packages/code/src/cli.ts

@@ -30,6 +30,7 @@
   "dependencies": {
     "@modelcontextprotocol/sdk": "^1.12.0",
     "@pleaseai/code-lsp": "workspace:*",
+    "@pleaseai/logger": "workspace:*",
     "zod": "^3.25.0"
   },
   "devDependencies": {

packages/dora/package.json

@@ -10,9 +10,12 @@
 
 import process from 'node:process'
 import { StdioServerTransport } from '@modelcontextprotocol/sdk/server/stdio.js'
+import { createLogger } from '@pleaseai/logger'
 import pkg from '../package.json'
 import { createDoraServer } from './server'
 
+const log = createLogger('dora')
+
 const VERSION = pkg.version
 
 interface ParsedArgs {
@@ -48,13 +51,13 @@ function parseArgs(argv: string[]): ParsedArgs {
 }
 
 async function serveCommand(projectPath: string, timeout: number): Promise<void> {
-  console.error(`[dora] Starting MCP server for project: ${projectPath}`)
+  log.info({ projectPath }, 'Starting MCP server')
 
   const server = await createDoraServer({ projectPath, timeout })
   const transport = new StdioServerTransport()
 
   await server.connect(transport)
-  console.error('[dora] MCP server connected and ready')
+  log.info('MCP server connected and ready')
 }
 
 function versionCommand(): void {
@@ -122,6 +125,6 @@ async function main(): Promise<void> {
 }
 
 main().catch((error) => {
-  console.error('[dora] Error:', error)
+  log.fatal({ err: error }, 'Unhandled error')
   process.exit(1)
 })

packages/dora/src/cli.ts

@@ -3,9 +3,12 @@
  * Scans ports 24226-24245 to find the running IDE instance
  */
 
+import { createLogger } from '@pleaseai/logger'
 import { ServerNotFoundError } from '../errors'
 import { transformResponse } from './response-transformer'
 
+const log = createLogger('dora')
+
 const BASE_PORT = 0x5EA2 // 24226
 const PORT_RANGE = 20
 const DISCOVERY_TIMEOUT = 1000 // 1 second for port discovery
@@ -74,7 +77,7 @@ export async function discoverPort(projectPath: string): Promise<number> {
     if (await checkPort(port, projectPath)) {
       cache.port = port
       cache.projectPath = projectPath
-      console.error(`[dora] Found JetBrains IDE service at port ${port}`)
+      log.debug({ port }, 'Found JetBrains IDE service')
       return port
     }
   }

packages/dora/src/client/port-discovery.ts

@@ -6,6 +6,7 @@
 
 import type { CliMatch, RunSgOptions, SgResult } from './types'
 import { existsSync } from 'node:fs'
+import { createLogger } from '@pleaseai/logger'
 import { spawn } from 'bun'
 import {
   CLI_LANGUAGES,
@@ -15,6 +16,8 @@ import {
 } from './constants'
 import { ensureAstGrepBinary, getInstallInstructions } from './downloader'
 
+const log = createLogger('ast-grep')
+
 // Cached binary path
 let resolvedCliPath: string | null = null
 
@@ -233,7 +236,7 @@ export async function runSg(options: RunSgOptions, retried = false): Promise<SgR
     else {
       // Non-truncated output but failed to parse - log and return error
       const errorMsg = parseError instanceof Error ? parseError.message : 'unknown'
-      console.error(`[ast-grep] Failed to parse output: ${errorMsg}`)
+      log.error({ err: errorMsg }, 'Failed to parse output')
       return {
         matches: [],
         totalMatches: 0,

packages/dora/src/providers/ast-grep/cli.ts

@@ -8,6 +8,7 @@
 import type { PlatformId } from './types'
 import { chmodSync, existsSync, mkdirSync, readFileSync, unlinkSync, writeFileSync } from 'node:fs'
 import process from 'node:process'
+import { createLogger } from '@pleaseai/logger'
 import { spawn } from 'bun'
 import {
   AST_GREP_VERSION,
@@ -18,6 +19,8 @@ import {
   PLATFORM_CONFIGS,
 } from './constants'
 
+const log = createLogger('ast-grep')
+
 /**
  * Verify a binary is actually ast-grep by checking --version output
  */
@@ -34,7 +37,7 @@ async function verifyAstGrepBinary(binaryPath: string): Promise<boolean> {
     return stdout.includes('ast-grep') || /^\d+\.\d+\.\d+/.test(stdout.trim())
   }
   catch (e) {
-    console.error(`[ast-grep] Binary verification failed for ${binaryPath}: ${e instanceof Error ? e.message : String(e)}`)
+    log.warn({ binaryPath, err: e }, 'Binary verification failed')
     return false
   }
 }
@@ -81,7 +84,7 @@ export function getCachedBinary(): string | null {
     }
     catch (e) {
       // Log warning but continue - will trigger re-download
-      console.warn(`[ast-grep] Failed to read version marker at ${versionPath}: ${e instanceof Error ? e.message : String(e)}`)
+      log.warn({ versionPath, err: e }, 'Failed to read version marker')
       return null
     }
   }
@@ -129,13 +132,13 @@ async function extractZip(archivePath: string, destDir: string): Promise<void> {
 export async function downloadAstGrepBinary(platformId?: PlatformId): Promise<string | null> {
   const platform = platformId ?? getPlatformId()
   if (!platform) {
-    console.error('[dora] Unsupported platform for ast-grep binary download')
+    log.error('Unsupported platform for ast-grep binary download')
     return null
   }
 
   const config = PLATFORM_CONFIGS[platform]
   if (!config) {
-    console.error(`[dora] No binary configuration for platform: ${platform}`)
+    log.error({ platform }, 'No binary configuration for platform')
     return null
   }
 
@@ -153,7 +156,7 @@ export async function downloadAstGrepBinary(platformId?: PlatformId): Promise<st
     }
   }
 
-  console.log(`[dora] Downloading ast-grep binary v${AST_GREP_VERSION}...`)
+  log.info({ version: AST_GREP_VERSION }, 'Downloading ast-grep binary')
 
   try {
     // Create cache directory
@@ -188,12 +191,12 @@ export async function downloadAstGrepBinary(platformId?: PlatformId): Promise<st
     // Write version marker
     writeFileSync(getVersionMarkerPath(), AST_GREP_VERSION)
 
-    console.log(`[dora] ast-grep binary ready at ${binaryPath}`)
+    log.info({ binaryPath }, 'ast-grep binary ready')
 
     return binaryPath
   }
   catch (err) {
-    console.error(`[dora] Failed to download ast-grep: ${err instanceof Error ? err.message : err}`)
+    log.error({ err }, 'Failed to download ast-grep')
     return null
   }
 }

packages/dora/src/providers/ast-grep/downloader.ts

@@ -7,12 +7,15 @@
 import type { Provider, ToolDefinition, ToolResult } from '../provider'
 import type { RegistryConfig } from '../registry'
 import type { NapiLanguage } from './types'
+import { createLogger } from '@pleaseai/logger'
 import { z, ZodError } from 'zod'
 import { isCliAvailable, runSg } from './cli'
 import { CLI_LANGUAGES, NAPI_LANGUAGES } from './constants'
 import { analyzeCode, getNapiError, isNapiAvailable, transformCode } from './napi'
 import { formatAnalyzeResult, formatReplaceResult, formatSearchResult, formatTransformResult, getEmptyResultHint } from './utils'
 
+const log = createLogger('ast-grep')
+
 /**
  * Format error for tool result, with special handling for Zod validation errors
  */
@@ -150,17 +153,16 @@ export class AstGrepProvider implements Provider {
     // Pre-check CLI availability (don't fail, just log)
     const cliAvailable = await isCliAvailable()
     if (!cliAvailable) {
-      console.log('[ast-grep] CLI not found, will download on first use')
+      log.debug('CLI not found, will download on first use')
     }
 
     // Check NAPI availability
     const napiAvailable = isNapiAvailable()
     if (!napiAvailable) {
       const error = getNapiError()
 
-      console.log(`[ast-grep] NAPI not available: ${error ?? 'unknown'}`)
-
-      console.log('[ast-grep] In-memory tools (analyze/transform) disabled')
+      log.debug({ error }, 'NAPI not available')
+      log.debug('In-memory tools (analyze/transform) disabled')
     }
 
     this.connected = true

packages/dora/src/providers/ast-grep/index.ts

@@ -6,8 +6,11 @@
  */
 
 import type { AnalyzeResult, MetaVariable, NapiLanguage, Range } from './types'
+import { createLogger } from '@pleaseai/logger'
 import { NAPI_LANGUAGES } from './constants'
 
+const log = createLogger('ast-grep')
+
 type AstGrepNapiModule = any
 
 type SgNode = any
@@ -33,7 +36,7 @@ export function isNapiAvailable(): boolean {
   catch (e) {
     napiLoadError = e instanceof Error ? e : new Error(String(e))
     // Log full error on first load failure for diagnostics
-    console.error('[ast-grep] NAPI module load failed:', e)
+    log.debug({ err: e }, 'NAPI module load failed')
     return false
   }
 }