Skip to content

Commit 3a1ecbf

Browse files
committed
refactor(skills): use SlashCommand for code review in subagent-driven-development
Replace Task tool code-reviewer dispatch with SlashCommand("/please:review-pr") for simpler and more consistent code review invocation. Changes: - SKILL.md: Updated step 3, 6, and example workflow - sequential_execution.md: Updated step 3, 6, and tips section
1 parent 7a2332a commit 3a1ecbf

2 files changed

Lines changed: 48 additions & 33 deletions

File tree

skills/subagent-driven-development/SKILL.md

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,16 @@ Task tool (general-purpose):
9595

9696
### 3. Review Subagent's Work
9797

98-
Dispatch code-reviewer subagent after each task:
98+
Run code review using SlashCommand after each task:
9999

100100
```
101-
Task tool (code-reviewer):
102-
WHAT_WAS_IMPLEMENTED: [from subagent's report]
103-
PLAN_OR_REQUIREMENTS: Task N from [plan-file]
104-
BASE_SHA: [commit before task]
105-
HEAD_SHA: [current commit]
106-
DESCRIPTION: [task summary]
101+
SlashCommand("/please:review-pr")
102+
```
103+
104+
Or with specific review aspects:
105+
106+
```
107+
SlashCommand("/please:review-pr code tests errors")
107108
```
108109

109110
**Code reviewer returns:** Strengths, Issues (Critical/Important/Minor), Assessment
@@ -127,10 +128,16 @@ If fixes needed, dispatch follow-up subagent:
127128

128129
### 6. Final Review
129130

130-
After all tasks complete, dispatch final code-reviewer:
131-
- Reviews entire implementation
132-
- Checks all plan requirements met
133-
- Validates overall architecture
131+
After all tasks complete, run comprehensive code review:
132+
133+
```
134+
SlashCommand("/please:review-pr all")
135+
```
136+
137+
This reviews:
138+
- Entire implementation
139+
- All plan requirements met
140+
- Overall architecture validation
134141

135142
## Example Workflow
136143

@@ -144,7 +151,7 @@ Task 1: Hook installation script
144151
[Dispatch implementation subagent]
145152
Subagent: Implemented install-hook with tests, 5/5 passing
146153
147-
[Get git SHAs, dispatch code-reviewer]
154+
[Run SlashCommand("/please:review-pr")]
148155
Reviewer: Strengths: Good test coverage. Issues: None. Ready.
149156
150157
[Mark Task 1 complete]
@@ -154,7 +161,7 @@ Task 2: Recovery modes
154161
[Dispatch implementation subagent]
155162
Subagent: Added verify/repair, 8/8 tests passing
156163
157-
[Dispatch code-reviewer]
164+
[Run SlashCommand("/please:review-pr")]
158165
Reviewer: Strengths: Solid. Issues (Important): Missing progress reporting
159166
160167
[Dispatch fix subagent]
@@ -165,7 +172,7 @@ Fix subagent: Added progress every 100 conversations
165172
...
166173
167174
[After all tasks]
168-
[Dispatch final code-reviewer]
175+
[Run SlashCommand("/please:review-pr all")]
169176
Final reviewer: All requirements met, ready to merge
170177
171178
Done!
@@ -215,7 +222,7 @@ Good agent prompts are:
215222
- `references/parallel_execution.md` - Parallel task execution
216223
- `references/parallel_investigation.md` - Debugging independent failures
217224

218-
## Related Skills
225+
## Related Commands & Skills
219226

220-
- `please:please-code-reviewer` - Code review agent
221-
- `general-purpose` - General implementation agent
227+
- `/please:review-pr` - Code review slash command (preferred for reviews)
228+
- `general-purpose` - General implementation agent for task execution

skills/subagent-driven-development/references/sequential_execution.md

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,16 @@ Task tool (general-purpose):
4242

4343
### Step 3: Review Subagent's Work
4444

45-
Dispatch code-reviewer subagent:
45+
Run code review using SlashCommand:
4646

4747
```
48-
Task tool (please:please-code-reviewer):
49-
WHAT_WAS_IMPLEMENTED: [from subagent's report]
50-
PLAN_OR_REQUIREMENTS: Task N from [plan-file]
51-
BASE_SHA: [commit before task]
52-
HEAD_SHA: [current commit]
53-
DESCRIPTION: [task summary]
48+
SlashCommand("/please:review-pr")
49+
```
50+
51+
Or with specific aspects:
52+
53+
```
54+
SlashCommand("/please:review-pr code tests errors")
5455
```
5556

5657
**Code reviewer returns:**
@@ -79,10 +80,16 @@ Task tool (please:please-code-reviewer):
7980

8081
### Step 6: Final Review
8182

82-
After all tasks complete, dispatch final code-reviewer:
83-
- Reviews entire implementation
84-
- Checks all plan requirements met
85-
- Validates overall architecture
83+
After all tasks complete, run comprehensive code review:
84+
85+
```
86+
SlashCommand("/please:review-pr all")
87+
```
88+
89+
This reviews:
90+
- Entire implementation
91+
- All plan requirements met
92+
- Overall architecture validation
8693

8794
### Step 7: Complete Development
8895

@@ -110,7 +117,7 @@ After final review passes:
110117

111118
1. Stop implementation of new tasks
112119
2. Dispatch fix subagent
113-
3. Re-run code review
120+
3. Re-run code review: `SlashCommand("/please:review-pr")`
114121
4. Only proceed when Critical issues resolved
115122

116123
## Tips for Success
@@ -126,10 +133,11 @@ After final review passes:
126133

127134
### Effective Code Reviews
128135

129-
Get git SHAs before dispatching reviewer:
130-
```bash
131-
git rev-parse HEAD~1 # BASE_SHA (before task)
132-
git rev-parse HEAD # HEAD_SHA (after task)
136+
Run code review after each task commit:
137+
```
138+
SlashCommand("/please:review-pr") # Default review
139+
SlashCommand("/please:review-pr code") # Code quality focus
140+
SlashCommand("/please:review-pr all") # Comprehensive review
133141
```
134142

135143
### Tracking Progress

0 commit comments

Comments
 (0)