Skip to content

Commit 2ea8a77

Browse files
committed
fix(ci): unblock release pipeline and auto-sync plugin code pins
The code-intelligence-lsp plugin runs `code lsp-multiplex`, but the pinned @pleaseai/code@0.1.13 predates that command (added in #100, unreleased), so the LSP server crashed with "Unknown command: lsp-multiplex". Releases were blocked because create-github-app-token had no app credentials. - ci: upgrade create-github-app-token v1 -> v3 and use client-id (recommended input; requires secrets CLIENT_ID and PRIVATE_KEY) - release: auto-bump every plugin's @pleaseai/code pin to the code version on each packages/code release via extra-files json updaters (pins were manual) - plugins: bump code-intelligence-lsp pin to 0.1.14 (the release that ships lsp-multiplex)
1 parent 95a84ac commit 2ea8a77

3 files changed

Lines changed: 22 additions & 5 deletions

File tree

.github/workflows/release-please.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,12 @@ jobs:
3333
release_created: ${{ steps.release.outputs.release_created }}
3434
tag_name: ${{ steps.release.outputs.tag_name }}
3535
steps:
36-
- uses: actions/create-github-app-token@v1
36+
- uses: actions/create-github-app-token@v3
3737
id: app-token
3838
with:
39-
app-id: ${{ secrets.PF_BOT_APP_ID }}
40-
private-key: ${{ secrets.PF_BOT_PRIVATE_KEY }}
39+
# client-id is the recommended input (supersedes the legacy app-id).
40+
client-id: ${{ secrets.CLIENT_ID }}
41+
private-key: ${{ secrets.PRIVATE_KEY }}
4142

4243
- uses: googleapis/release-please-action@v4
4344
id: release
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"private": true,
33
"dependencies": {
4-
"@pleaseai/code": "0.1.13"
4+
"@pleaseai/code": "0.1.14"
55
}
66
}

release-please-config.json

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,23 @@
6565
},
6666
"packages/code": {
6767
"release-type": "node",
68-
"component": "@pleaseai/code"
68+
"component": "@pleaseai/code",
69+
"extra-files": [
70+
{ "type": "json", "path": "plugins/clangd-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
71+
{ "type": "json", "path": "plugins/code-intelligence-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
72+
{ "type": "json", "path": "plugins/csharp-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
73+
{ "type": "json", "path": "plugins/dart-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
74+
{ "type": "json", "path": "plugins/elixir-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
75+
{ "type": "json", "path": "plugins/eslint-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
76+
{ "type": "json", "path": "plugins/fsharp-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
77+
{ "type": "json", "path": "plugins/jdtls-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
78+
{ "type": "json", "path": "plugins/kotlin-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
79+
{ "type": "json", "path": "plugins/lua-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
80+
{ "type": "json", "path": "plugins/rubocop-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
81+
{ "type": "json", "path": "plugins/terraform-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
82+
{ "type": "json", "path": "plugins/texlab-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
83+
{ "type": "json", "path": "plugins/zls-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }
84+
]
6985
},
7086
"packages/dora": {
7187
"release-type": "node",

0 commit comments

Comments
 (0)