fix: checkDependencies if no package was found (#142)

* fix: checkDependencies if no pkg was found

* Some fixes

* Add some tests

Co-authored-by: mmarkelov <[email protected]>

Author: mxschmitt

src/PlaywrightEnvironment.ts

@@ -31,7 +31,7 @@ const getBrowserPerProcess = async (
   // https://github.com/mmarkelov/jest-playwright/issues/42#issuecomment-589170220
   if (browserType !== CHROMIUM && launchBrowserApp && launchBrowserApp.args) {
     launchBrowserApp.args = launchBrowserApp.args.filter(
-      (item) => item !== '--no-sandbox',
+      (item: string) => item !== '--no-sandbox',
     )
   }
 

src/utils.test.ts

@@ -153,6 +153,16 @@ describe('checkDeviceEnv', () => {
 })
 
 describe('checkDependencies', () => {
+  it('should return null for empty dependencies', () => {
+    const dep = checkDependencies({})
+    expect(dep).toBe(null)
+  })
+
+  it('should return null for dependencies without playwright packages', () => {
+    const dep = checkDependencies({ test: '0.0.1' })
+    expect(dep).toBe(null)
+  })
+
   it('should return right package object for single package', () => {
     const dep = checkDependencies({ 'playwright-chromium': '*' })
     expect(dep).toStrictEqual({ [CHROMIUM]: CHROMIUM })
@@ -215,6 +225,24 @@ describe('readPackage', () => {
       { virtual: true },
     )
 
+    const playwright = await readPackage()
+    expect(playwright).toStrictEqual({ [FIREFOX]: FIREFOX })
+  })
+  it('should return playwright-firefox when it is defined and empty dependencies are persistent', async () => {
+    ;((fs.exists as unknown) as jest.Mock).mockImplementationOnce(
+      (_, cb: (exists: boolean) => void) => cb(true),
+    )
+    jest.mock(
+      path.join(__dirname, '..', 'package.json'),
+      () => ({
+        dependencies: {},
+        devDependencies: {
+          'playwright-firefox': '*',
+        },
+      }),
+      { virtual: true },
+    )
+
     const playwright = await readPackage()
     expect(playwright).toStrictEqual({ [FIREFOX]: FIREFOX })
   })

src/utils.ts

@@ -16,7 +16,7 @@ export const checkDependencies = (
   dependencies: Record<string, string>,
 ): Packages | typeof IMPORT_KIND_PLAYWRIGHT | null => {
   const packages: Packages = {}
-  if (!dependencies) return null
+  if (!dependencies || Object.keys(dependencies).length === 0) return null
   if (dependencies.playwright) return IMPORT_KIND_PLAYWRIGHT
   if (dependencies[`playwright-${CHROMIUM}`]) {
     packages[CHROMIUM] = CHROMIUM
@@ -27,6 +27,9 @@ export const checkDependencies = (
   if (dependencies[`playwright-${WEBKIT}`]) {
     packages[WEBKIT] = WEBKIT
   }
+  if (Object.keys(packages).length === 0) {
+    return null
+  }
   return packages
 }
 
@@ -85,7 +88,7 @@ export const readPackage = async (): Promise<
   const playwright =
     checkDependencies(packageConfig.dependencies) ||
     checkDependencies(packageConfig.devDependencies)
-  if (!playwright || !Object.keys(playwright).length) {
+  if (playwright === null) {
     throw new Error('None of playwright packages was not found in dependencies')
   }
   return playwright