Merge pull request #227 from plausible/improve_token_validation

Fix #224 - If no token is entered, the ClientFactory will no longer return a Client instance.

Author: Dan0sz

src/Client.php

@@ -34,7 +34,7 @@ class Client {
 	 */
 	public function __construct( $token = '' ) {
 		$config             = Configuration::getDefaultConfiguration()->setUsername( 'WordPress' )->setPassword(
-			$token ?: Helpers::get_settings()[ 'api_token' ]
+			$token
 		)->setHost( Helpers::get_hosted_domain_url() );
 		$this->api_instance = new DefaultApi( new GuzzleClient(), $config );
 	}

src/ClientFactory.php

@@ -34,6 +34,14 @@ public function build() {
 			return false; // @codeCoverageIgnore
 		}
 
+		if ( ! $this->token ) {
+			$this->token = Helpers::get_settings()[ 'api_token' ];
+		}
+
+		if ( ! $this->token ) {
+			return false;
+		}
+
 		return new Client( $this->token );
 	}
 

tests/unit/ClientFactoryTest.php

@@ -17,6 +17,11 @@ public function testBuild() {
 		$clientFactory = new ClientFactory();
 		$client        = $clientFactory->build();
 
+		$this->assertFalse( $client );
+
+		$clientFactory = new ClientFactory( 'test' );
+		$client        = $clientFactory->build();
+
 		$this->assertInstanceOf( Client::class, $client );
 	}
 }