Skip to content

[Tracker] Scroll-depth tracking still forces layout on large pages after #6174 #6764

Open

Description

@trotzig

Past Issues Searched

  • I have searched open and closed issues to make sure that the bug has not yet been reported

Issue is a Bug Report

  • This is a bug report and not a feature request, nor asking for self-hosted support

Using official Plausible Cloud hosting or self-hosting?

Plausible Cloud from plausible.io

Describe the bug

This is what remains of #5727 after the fix in #6174. With @plausible-analytics/tracker 0.4.6 (npm), the scroll-depth measurement still forces synchronous layout, in two places:

  1. The ResizeObserver on document.documentElement, whose callback reads scrollHeight, offsetHeight and clientHeight on both body and documentElement.
  2. The scroll listener on document, which reads window.scrollY and window.innerHeight.

When layout is dirty at the time these run, each read makes the browser complete a full layout right then. On a small page that is negligible. On a page with a very large DOM it blocks the main thread for hundreds of milliseconds.

What we measured

We were investigating intermittent freezes on a long list page in our app (about 180,000 DOM elements). We recorded frames with the Long Animation Frames API (PerformanceObserver with type: 'long-animation-frame'), which attributes the time in each frame to individual scripts and reports forcedStyleAndLayoutDuration per script.

Frame Total blocked Tracker's share
First frame after load 1,391 ms ResizeObserverCallback: 670 ms, of which 645 ms forced style and layout
A frame while scrolling 142 ms document.onscroll: 71 ms, of which 61 ms forced style and layout

Both entries pointed at the tracker's code in our bundle. In the published plausible.js it is this:

function E(){var e=document.body||{},t=document.documentElement||{};return Math.max(e.scrollHeight||0,e.offsetHeight||0,e.clientHeight||0,t.scrollHeight||0,t.offsetHeight||0,t.clientHeight||0)}
function L(){var e,t;return e=window.innerHeight,t=window.scrollY,i<=e?i:t+e}
function S(){i=E(),o=L(),new ResizeObserver(function(){i=E()}).observe(document.documentElement),document.addEventListener("scroll",function(){var e=L();e>o&&(o=e)})}

The page renders items lazily as they approach the viewport, so the document's height changes often, and each change fires the ResizeObserver again.

We did not identify what leaves layout dirty before the tracker's callback runs. Other ResizeObserver callbacks in the same delivery round, or writes earlier in the frame, would do it. The cost lands in the tracker's callback because it is the one that reads.

The tracker is initialised with init({ domain, autoCapturePageviews: false, captureOnLocalhost: false, customProperties }).

Expected behavior

Scroll-depth bookkeeping should not force layout inside a rendering frame, or it should be possible to turn it off.

Some options:

  • Defer the reads to a point where layout is already clean, for example requestIdleCallback with a timer fallback, and coalesce repeated calls. The values are only sent with the engagement event, so they don't need to be exact within a frame.
  • In the ResizeObserver callback, use the sizes on the delivered entries where possible, instead of re-reading scrollHeight and the others.
  • Add an init option to turn engagement or scroll-depth tracking off, which several people also asked for in Tracking script causes forced reflow of the page #5727.

As a workaround we wrap init() so that, for the duration of that call, ResizeObserver and document.addEventListener('scroll', …) hand the tracker callbacks that are deferred to idle time. It relies on patching globals around a call into the library, so we'd rather not keep it.

Screenshots

No response

Environment

- OS: macOS
- Browser: Chrome
- Browser Version:
- Tracker: @plausible-analytics/tracker 0.4.6 (npm package)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions