Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VTAdmin setting for fetch credentials to CRD #549

Open
leejones opened this issue Apr 11, 2024 · 0 comments
Open

Add VTAdmin setting for fetch credentials to CRD #549

leejones opened this issue Apr 11, 2024 · 0 comments

Comments

@leejones
Copy link

leejones commented Apr 11, 2024

We deploy VTAdmin using the vitess-operator and make it accessible using an authenticated proxy. In order for it to work, we need the frontend to send the user's HTTP Cookie containing their credentials when the frontend Javascript makes requests to the VTAdmin API. By default, this is currently disabled by the operator. We'd like the option to change this setting in the CRD (e.g. change to same-origin).

For example, something like this would be great:

kind: VitessCluster:
spec:
  vtadmin:
    fetchCredentials: same-origin

The default could remain omit for backwards compatibility and/or security.

Currently we workaround this missing setting by mounting a custom nginx config that serves a custom config.js instead of the one rendered by the operator.

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant