Len 0 values logged as 0x in responses

[kriztalz]

When certain TLS extensions of len 0 are used in the Client Hello of a request, rama returns 0x.

Example for a TLS 1.2 curl request to echo.ramaproxy.org:

"tls": {
             ...
      {
        "data": "0x",
        "id": "NEXT_PROTOCOL_NEGOTIATION (0x3374)"
      },
      {
        "data": [
          "h2",
          "http/1.1"
        ],
        "id": "APPLICATION_LAYER_PROTOCOL_NEGOTIATION (0x0010)"
      },
      {
        "data": "0x",
        "id": "ENCRYPT_THEN_MAC (0x0016)"
      },
      {
        "data": "0x",
        "id": "EXTENDED_MASTER_SECRET (0x0017)"
      }
}

[GlenDC]

Good catch. Is this something you are willing to pickup?

For those that want to pick it up, here are the locations to start your patch journey:

• echo service:

  rama/src/cli/service/echo.rs

  Line 419 in d0ca232

  "data": format!("0x{}", hex::encode(data)),

• fp service: turn this data object into an option:

  rama/rama-cli/src/cmd/fp/data.rs

  Line 261 in d0ca232

  pub(super) data: TlsDisplayInfoExtensionData,

  which will allow you to omit it if no data

[airycanon]

@GlenDC I would like to have a try, could you please assign to me?

[GlenDC]

Sure thing. All yours. Do let me know if you need help.