Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Clean Up Layout on Package Details View #655

Open
tsmitty11 opened this issue Jun 6, 2023 · 10 comments · Fixed by #724
Open

Clean Up Layout on Package Details View #655

tsmitty11 opened this issue Jun 6, 2023 · 10 comments · Fixed by #724

Comments

@tsmitty11
Copy link
Contributor

I have a more up-to-date design that takes all of the buttons into consideration and rearranges them into a more appealing layout. Please let @tsmitty11 if you have any questions as it relates to the design.

Screen Shot 2023-06-06 at 4 11 28 PM
@getneil
Copy link
Contributor

getneil commented Jul 18, 2023

@tsmitty11 the in-app-terminal pr for SD has been merged, this need to be updated.

@tsmitty11
Copy link
Contributor Author

@getneil thanks Neil, I'll update with a new design.

@tsmitty11
Copy link
Contributor Author

Here's a Loom video. I think @mxcl intended for the tabs to open the cli and gui respectively, so we can probably omit the 'open in terminal' button... but he can confirm yay or nay.

https://www.loom.com/share/978f8e766fd043908d50702b2c9a186e?sid=5fe72fd6-f215-4761-aa4e-b5dd14a77723

Assuming that's the case, here's the install state:

Screen Shot 2023-07-18 at 11 28 50 PM

And the installed/update state:

Screen Shot 2023-07-18 at 11 28 59 PM

@mxcl
Copy link
Member

mxcl commented Jul 21, 2023

we shouldn't omit the open button it's the major CTA and should be positioned accoringly

@mxcl
Copy link
Member

mxcl commented Jul 21, 2023

Screenshot 2023-07-21 at 10 16 34 AM

can we ensure that the layout at the default size the app opens at on clean installs involves no wrap? Thanks

@tsmitty11
Copy link
Contributor Author

@mxcl thoughts on this? Leaves more horizontal space for the CTA lockup. Also allows a bit flexibility for the description text as it's confined to it's own row here.

Screen Shot 2023-07-21 at 7 21 04 PM

@tsmitty11
Copy link
Contributor Author

No text next to button; re: good point from Alan

Screen Shot 2023-07-21 at 7 34 48 PM

@mxcl
Copy link
Member

mxcl commented Jul 23, 2023

superb. approved

@tsmitty11
Copy link
Contributor Author

@getneil @ABevier pushing this to top, as issue was technically closed. See above for details design approved by mxcl.

https://www.figma.com/file/UZJ2CrxsoX0pkhEY4NZE5j/GUI-Master?type=design&node-id=749%3A3619&mode=dev

@getneil getneil reopened this Jul 24, 2023
@getneil
Copy link
Contributor

getneil commented Jul 24, 2023

sorry about that it was linked to a PR. that was merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants