Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easy way to check if membership is paid or not #10

Open
tobixen opened this issue Jan 14, 2016 · 2 comments
Open

easy way to check if membership is paid or not #10

tobixen opened this issue Jan 14, 2016 · 2 comments
Assignees
@asbjornu
Milestone
Production

Comments

@tobixen
Copy link
Member

tobixen commented Jan 14, 2016

A member is to be regarded as a member only when the membership fee is paid - but with the current db schema it's needed to do a subquery into the payments table to find out. That's suboptimal.

We should ...

... either add a redundant attribute for "last membership paid" (date or year) in the user table, and provide triggers (or an update script) to populate it ...

... or fix this through a database view
@tobixen tobixen self-assigned this Jan 14, 2016
@tobixen tobixen assigned asbjornu and unassigned tobixen Jan 27, 2016
@tobixen
Copy link
Member Author

tobixen commented Jan 27, 2016

We've considered it would be a good idea to implement "register payment" as an API method in drywall. Should probably go via rabbitmq eventually.

@tobixen tobixen added this to the Production milestone Jan 27, 2016
@tobixen
Copy link
Member Author

tobixen commented Jan 27, 2016

Depends on issue #16

asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Changed test suite to use mocha for #10; WIP
123032c 
Update the test suite to use Mocha. This tests results in creation of
the model objects in /models. The ultimate goal is to create unit tests
that are not dependent upon the actual database, in order to enforce
separation.

- package.json - Changed the npm test command to use a test runner named
  `test.js` which starts mocha with some configuration options set. Also
  added other packages to be used with testing, including:
  * lodash
  * factory-girl
  * factory-girl-sequelize
  * faker

- test.js - Test runner starting Mocha with standard options.

- specs/index-spec.js - Old supertest based test that no longer applies.

- specs/models/AccountSpec.js - Unit test that checks the functionality
  of the Accont model.

- models/Account.js - Changed the jshint to use 4 spaces.
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Updated node version for Travis; #10
3fe2a70 
Updated to use latest LTS and Stable versions of Node
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
updated GCC options for compiling bcrypt; #10
675ca7c 
Adds an option to compile bcrypt so that it can compile successfully.
This is based on the bug entered at:
travis-ci/travis-ci#4771
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Testing out setupTestDatabases.sh; #10
8ea35cd 
- .travis.yml - Added call to setupTestDatabases.sh in before_script

- bin/setupTestDatabases.sh - Proof of concept that echoes "Running Test
  Database Script"
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
changed tab to spaces; #10
2637df3 
- .travis.yml - changed tab to space
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Made startup script executable: #10
7c6087d 
- .travis.yml - Made the setup test executable and then run it
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Continuous Integration Database Setup; #10
4e7b830 
- bin/setupTestDatabases.sh - Copy config.json.tmpl to config.json
  create a test database and update the username & password database to
  match the newly created database.
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Updated script to show template output; #10
844e73b
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Changed echo to cat #10
739c312
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Manually create database; #10
a078e68
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Changed "127.0.0.1" to "localhost"; #10
70ae68b
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Added diagnostics to account spec #10
b4efa33 
Added a console.log to the account spec
asbjornu pushed a commit that referenced this issue Apr 15, 2016
@msnyon
Remove console.log from AccountSpec; #10
89ff9b7 
- specs/models/AccountSpec.js - Removed unused spec from Account.js
asbjornu added a commit that referenced this issue Apr 15, 2016
@asbjornu
Merge remote-tracking branch 'trystant/master' into feature/merge-try…
0781be5 
…stant-master

* trystant/master: (28 commits)
  Updated Postgres system requirement for #22
  Updated README.md installation process
  Updated README.md with testing info
  Updated README to remove supertest
  Added codeclimate test coverage badge; #20
  Changed Markdown version to HTML for README.md #20
  Updated README.md and removed unused code; #20
  Changed lcov.info location for code climate;  #20
  Added commands to generate lcov data; #20
  Added config variables to help test coverage; #20
  Added istanbul & configured for test coverage; #20
  Added Code Climate badge; #20
  Added CodeClimate badge to the README.md; #20
  Remove console.log from AccountSpec; #10
  Added diagnostics to account spec #10
  Changed "127.0.0.1" to "localhost"; #10
  Manually create database; #10
  Quoted replacement values
  Changed echo to cat #10
  Updated script to show template output; #10
  ...

# Conflicts:
#	.travis.yml
#	README.md
#	app.js
#	config/config.json.tmpl
#	models/Account.js
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asbjornu asbjornu

Labels
None yet
Projects
None yet
Milestone
Production
Development

No branches or pull requests
2 participants
@asbjornu @tobixen