Lint fixes based on phpstan report

Author: pionl

src/Handler/ChunksInRequestUploadHandler.php

@@ -125,7 +125,7 @@ public function isFirstChunk()
     /**
      * Checks if the chunk is last.
      *
-     * @return int
+     * @return bool
      */
     public function isLastChunk()
     {

src/Handler/ContentRangeUploadHandler.php

@@ -36,21 +36,21 @@ class ContentRangeUploadHandler extends AbstractHandler
     /**
      * Current chunk start bytes.
      *
-     * @var int
+     * @var float
      */
     protected $bytesStart = 0;
 
     /**
      * Current chunk bytes end.
      *
-     * @var int
+     * @var float
      */
     protected $bytesEnd = 0;
 
     /**
      * The files total bytes.
      *
-     * @var int
+     * @var float
      */
     protected $bytesTotal = 0;
 
@@ -153,7 +153,7 @@ public function isFirstChunk()
     /**
      * Returns the chunks count.
      *
-     * @return int
+     * @return bool
      */
     public function isLastChunk()
     {
@@ -172,23 +172,23 @@ public function isChunkedUpload()
     }
 
     /**
-     * @return int returns the starting bytes for current request
+     * @return float returns the starting bytes for current request
      */
     public function getBytesStart()
     {
         return $this->bytesStart;
     }
 
     /**
-     * @return int returns the ending bytes for current request
+     * @return float returns the ending bytes for current request
      */
     public function getBytesEnd()
     {
         return $this->bytesEnd;
     }
 
     /**
-     * @return int returns the total bytes for the file
+     * @return float returns the total bytes for the file
      */
     public function getBytesTotal()
     {

src/Handler/HandlerFactory.php

@@ -37,7 +37,7 @@ class HandlerFactory
      */
     public static function classFromRequest(Request $request, $fallbackClass = null)
     {
-        /** @var AbstractHandler $handlerClass */
+        /** @var AbstractHandler|string $handlerClass */
         foreach (static::$handlers as $handlerClass) {
             if ($handlerClass::canBeUsedForRequest($request)) {
                 return $handlerClass;

src/Handler/SingleUploadHandler.php

@@ -2,7 +2,6 @@
 
 namespace Pion\Laravel\ChunkUpload\Handler;
 
-use Pion\Laravel\ChunkUpload\Config\AbstractConfig;
 use Pion\Laravel\ChunkUpload\Save\SingleSave;
 use Pion\Laravel\ChunkUpload\Storage\ChunkStorage;
 
@@ -16,7 +15,7 @@ class SingleUploadHandler extends AbstractHandler
     /**
      * Returns the chunks ave instance for saving.
      *
-     * @param ChunkStorage   $chunkStorage the chunk storage
+     * @param ChunkStorage $chunkStorage the chunk storage
      *
      * @return SingleSave
      */
@@ -32,7 +31,7 @@ public function startSaving($chunkStorage)
      */
     public function getChunkFileName()
     {
-        return null; // never used
+        return ''; // never used
     }
 
     /**

src/Receiver/FileReceiver.php

@@ -25,7 +25,7 @@ class FileReceiver
     protected $file;
 
     /**
-     * The handler that detects what upload proccess is beeing used.
+     * The handler that detects what upload process is being used.
      *
      * @var AbstractHandler
      */
@@ -93,7 +93,7 @@ public function isUploaded()
      */
     public function receive()
     {
-        if (false === is_object($this->handler)) {
+        if (false == is_object($this->handler)) {
             return false;
         }
 

src/Save/ChunkSave.php

@@ -2,6 +2,7 @@
 
 namespace Pion\Laravel\ChunkUpload\Save;
 
+use Illuminate\Contracts\Filesystem\Filesystem as FilesystemContract;
 use Illuminate\Http\UploadedFile;
 use Pion\Laravel\ChunkUpload\Config\AbstractConfig;
 use Pion\Laravel\ChunkUpload\Exceptions\ChunkSaveException;
@@ -154,7 +155,7 @@ protected function handleChunk()
         $file = $this->getChunkFilePath();
 
         $this->handleChunkFile($file)
-            ->tryToBuildFullFileFromChunks();
+             ->tryToBuildFullFileFromChunks();
     }
 
     /**
@@ -242,7 +243,7 @@ public function chunkStorage()
     /**
      * Returns the disk adapter for the chunk.
      *
-     * @return \Illuminate\Filesystem\FilesystemAdapter
+     * @return FilesystemContract
      */
     public function chunkDisk()
     {

src/Save/ParallelSave.php

@@ -3,6 +3,7 @@
 namespace Pion\Laravel\ChunkUpload\Save;
 
 use Illuminate\Http\UploadedFile;
+use Illuminate\Support\Collection;
 use Illuminate\Support\Str;
 use Pion\Laravel\ChunkUpload\ChunkFile;
 use Pion\Laravel\ChunkUpload\Config\AbstractConfig;
@@ -31,10 +32,10 @@ class ParallelSave extends ChunkSave
     /**
      * ParallelSave constructor.
      *
-     * @param UploadedFile                              $file         the uploaded file (chunk file)
-     * @param AbstractHandler|HandleParallelUploadTrait $handler      the handler that detected the correct save method
-     * @param ChunkStorage                              $chunkStorage the chunk storage
-     * @param AbstractConfig                            $config       the config manager
+     * @param UploadedFile    $file         the uploaded file (chunk file)
+     * @param AbstractHandler $handler      the handler that detected the correct save method
+     * @param ChunkStorage    $chunkStorage the chunk storage
+     * @param AbstractConfig  $config       the config manager
      *
      * @throws ChunkSaveException
      */
@@ -79,7 +80,7 @@ protected function tryToBuildFullFileFromChunks()
     /**
      * Searches for all chunk files.
      *
-     * @return \Illuminate\Support\Collection
+     * @return Collection
      */
     protected function getSavedChunksFiles()
     {

src/Storage/ChunkStorage.php

@@ -32,7 +32,7 @@ public static function storage()
     /**
      * The disk that holds the chunk files.
      *
-     * @var \Illuminate\Filesystem\FilesystemAdapter
+     * @var FilesystemContract
      */
     protected $disk;
 
@@ -172,7 +172,7 @@ public function config()
     }
 
     /**
-     * @return \Illuminate\Filesystem\FilesystemAdapter
+     * @return FilesystemContract
      */
     public function disk()
     {