Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tikv rpc cli #6057

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Tikv rpc cli #6057

wants to merge 6 commits into from

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Feb 5, 2025

What problem does this PR solve?

During rolling restart, the lag of log backup may be increased because progress lost of the restarted TiKV.

Closes #6046

What is changed and how does it work?

This added a gRPC Client to TiKV and manually triggered FlushNow when gracefully restarting a TiKV.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gozssky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L label Feb 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 15.55556% with 76 lines in your changes missing coverage. Please review.

Project coverage is 55.66%. Comparing base (a16b2e8) to head (36e0be9).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6057      +/-   ##
==========================================
- Coverage   57.19%   55.66%   -1.54%     
==========================================
  Files         259      266       +7     
  Lines       33233    46260   +13027     
==========================================
+ Hits        19008    25750    +6742     
- Misses      12291    18504    +6213     
- Partials     1934     2006      +72     
Flag Coverage Δ
unittest 55.66% <15.55%> (-1.54%) ⬇️

Signed-off-by: hillium <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log backup: support log file flush during tikv graceful shutdown
3 participants