Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

production build failed for new CI #371

Closed
634750802 opened this issue Feb 25, 2022 · 4 comments · Fixed by #374
Closed

production build failed for new CI #371

634750802 opened this issue Feb 25, 2022 · 4 comments · Fixed by #374
Assignees
@xiyan128
Labels
bug Something isn't working P1

Comments

@634750802
Copy link
Collaborator

See c0406a1 for production build log

Sentry's env was not passed while building, please add:

  • SENTRY_TOKEN (already configured)
  • SENTRY_RELEASE(should be dynamically generated)

to build phase.
@634750802 634750802 added the bug Something isn't working label Feb 25, 2022
@634750802 634750802 mentioned this issue Feb 25, 2022
Merged
@634750802 634750802 reopened this Feb 26, 2022
@634750802
Copy link
Collaborator Author

not fixed by #374

634750802 added a commit that referenced this issue Feb 26, 2022
@634750802
fix(#371): prod ci
7a1e4d5
@634750802 634750802 added the P1 label Feb 26, 2022
@xiyan128
Copy link
Contributor

Fix attempted in #376. Not quite sure about the production ci behavior though. @634750802

@634750802 634750802 mentioned this issue Feb 28, 2022
Merged
@634750802
Copy link
Collaborator Author

Not work https://github.com/pingcap-inc/tidb.io/runs/5354241879?check_suite_focus=true

@634750802 634750802 reopened this Feb 28, 2022
@cw1997
Copy link
Contributor

cw1997 commented Mar 22, 2022

It works now after I set the config 'ignoreEmpty' to true, refer to this commit: 8bd86a9

@cw1997 cw1997 closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiyan128 xiyan128

Labels
bug Something isn't working P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: optimization pingcap-inc/community-website
3 participants
@cw1997 @634750802 @xiyan128