From 15db02cb8b4df5efe5d79dc1fe20579fd180b2e1 Mon Sep 17 00:00:00 2001
From: lukmzig <lukas.mzigot@pimcore.com>
Date: Tue, 5 Nov 2024 10:46:44 +0100
Subject: [PATCH 1/3] fix: base permissions should be false by default

---
 src/Permission/BasePermissions.php | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/Permission/BasePermissions.php b/src/Permission/BasePermissions.php
index 590a1761..665009d1 100644
--- a/src/Permission/BasePermissions.php
+++ b/src/Permission/BasePermissions.php
@@ -21,8 +21,7 @@
  */
 abstract class BasePermissions
 {
-    // TODO: Change default value once development of API is finished
-    protected const DEFAULT_VALUE = true;
+    protected const DEFAULT_VALUE = false;
 
     private bool $list = self::DEFAULT_VALUE;
 

From 73e16bf3a0764bc9e7469443a4c89ec8beb79d1b Mon Sep 17 00:00:00 2001
From: lukmzig <lukas.mzigot@pimcore.com>
Date: Tue, 5 Nov 2024 11:06:34 +0100
Subject: [PATCH 2/3] fix: codeception unit tests

---
 tests/Unit/Service/EventServiceTest.php                | 10 +++++-----
 .../Unit/Service/Permission/PermissionServiceTest.php  |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/Unit/Service/EventServiceTest.php b/tests/Unit/Service/EventServiceTest.php
index 430ee86c..c00e10d0 100644
--- a/tests/Unit/Service/EventServiceTest.php
+++ b/tests/Unit/Service/EventServiceTest.php
@@ -36,8 +36,8 @@ final class EventServiceTest extends Unit
     public function testDispatchAssetSearchEvent(): void
     {
         $permissions = new AssetPermissions();
-        $permissions->setView(false);
-        $permissions->setRename(false);
+        $permissions->setView(true);
+        $permissions->setRename(true);
 
         $event = new Event\Asset\PermissionEvent(
             new AssetSearchResultItem(),
@@ -51,9 +51,9 @@ public function testDispatchAssetSearchEvent(): void
         );
 
         $this->assertSame($event->getPermissions(), $returnedEvent->getPermissions());
-        $this->assertFalse($returnedEvent->getPermissions()->isView());
-        $this->assertFalse($returnedEvent->getPermissions()->isRename());
-        $this->assertTrue($returnedEvent->getPermissions()->isList());
+        $this->assertTrue($returnedEvent->getPermissions()->isView());
+        $this->assertTrue($returnedEvent->getPermissions()->isRename());
+        $this->assertFalse($returnedEvent->getPermissions()->isList());
     }
 
     public function testDispatchDataObjectSearchEvent(): void
diff --git a/tests/Unit/Service/Permission/PermissionServiceTest.php b/tests/Unit/Service/Permission/PermissionServiceTest.php
index 9b071025..ef630d61 100644
--- a/tests/Unit/Service/Permission/PermissionServiceTest.php
+++ b/tests/Unit/Service/Permission/PermissionServiceTest.php
@@ -39,7 +39,7 @@
  */
 final class PermissionServiceTest extends Unit
 {
-    private const DEFAULT_VALUE = true;
+    private const DEFAULT_VALUE = false;
 
     private User $user;
 

From 3aafd7040ba0f0acb1b85bf969e73d913b7f16e4 Mon Sep 17 00:00:00 2001
From: lukmzig <lukas.mzigot@pimcore.com>
Date: Tue, 5 Nov 2024 11:07:43 +0100
Subject: [PATCH 3/3] fix: codeception unit tests

---
 tests/Unit/Service/EventServiceTest.php | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/tests/Unit/Service/EventServiceTest.php b/tests/Unit/Service/EventServiceTest.php
index c00e10d0..fd1621d0 100644
--- a/tests/Unit/Service/EventServiceTest.php
+++ b/tests/Unit/Service/EventServiceTest.php
@@ -59,8 +59,8 @@ public function testDispatchAssetSearchEvent(): void
     public function testDispatchDataObjectSearchEvent(): void
     {
         $permissions = new DataObjectPermissions();
-        $permissions->setView(false);
-        $permissions->setRename(false);
+        $permissions->setView(true);
+        $permissions->setRename(true);
 
         $event = new Event\DataObject\PermissionEvent(
             new DataObjectSearchResultItem(),
@@ -74,16 +74,16 @@ public function testDispatchDataObjectSearchEvent(): void
         );
 
         $this->assertSame($event->getPermissions(), $returnedEvent->getPermissions());
-        $this->assertFalse($returnedEvent->getPermissions()->isView());
-        $this->assertFalse($returnedEvent->getPermissions()->isRename());
-        $this->assertTrue($returnedEvent->getPermissions()->isList());
+        $this->assertTrue($returnedEvent->getPermissions()->isView());
+        $this->assertTrue($returnedEvent->getPermissions()->isRename());
+        $this->assertFalse($returnedEvent->getPermissions()->isList());
     }
 
     public function testDispatchDocumentSearchEvent(): void
     {
         $permissions = new DocumentPermissions();
-        $permissions->setView(false);
-        $permissions->setList(false);
+        $permissions->setView(true);
+        $permissions->setList(true);
 
         $event = new Event\Document\PermissionEvent(
             new DocumentSearchResultItem(),
@@ -97,9 +97,9 @@ public function testDispatchDocumentSearchEvent(): void
         );
 
         $this->assertSame($event->getPermissions(), $returnedEvent->getPermissions());
-        $this->assertFalse($returnedEvent->getPermissions()->isView());
-        $this->assertFalse($returnedEvent->getPermissions()->isList());
-        $this->assertTrue($returnedEvent->getPermissions()->isPublish());
+        $this->assertTrue($returnedEvent->getPermissions()->isView());
+        $this->asserttrue($returnedEvent->getPermissions()->isList());
+        $this->assertFalse($returnedEvent->getPermissions()->isPublish());
     }
 
     public function testEventDispatcherCall(): void