package_core: fix GitHub Actions logging syntax

Use a common function to handle logging messages for GitHub Actions and
for the console, for a cleaner output.

Signed-off-by: Luca Burelli <[email protected]>

:1

Author: pillo79

extra/package_core.sh

@@ -16,6 +16,14 @@ ARTIFACT=$1
 VERSION=$2
 OUTPUT_FILE=${3:-distrib/${ARTIFACT}-${VERSION}.tar.bz2}
 
+log_msg() {
+	if [ -n $GITHUB_WORKSPACE ] ; then
+		echo "::$1::$2"
+	else
+		echo "$2"
+	fi
+}
+
 # we use variants for include because we filter on file paths
 # and boards for exclude because we want to remove matching lines in boards.txt
 BOARD_DETAILS=$(extra/get_board_details.sh)
@@ -31,7 +39,7 @@ else
 	EXCLUDED_BOARDS=$(echo ${BOARD_DETAILS} | jq -cr "map(select(.artifact != \"$ARTIFACT\")) | .[].board")
 fi
 
-[ -n $GITHUB_WORKSPACE ] && echo "::group::Packaging ${ARTIFACT_NAME:-all variants} ($(basename $OUTPUT_FILE))"
+log_msg group "Packaging ${ARTIFACT_NAME:-all variants} ($(basename $OUTPUT_FILE))"
 
 # create a temporary boards.txt file with the correct list of boards
 TEMP_BOARDS=$(mktemp -p . | sed 's/\.\///')
@@ -50,6 +58,7 @@ cat platform.txt > ${TEMP_PLATFORM}
 sed -ie "s/^version=.*/version=$(extra/get_core_version.sh)/" ${TEMP_PLATFORM}
 
 declutter_file() {
+	# remove comments and empty lines
 	[ -f "$1" ] || return 0
 	cat "$1" | sed -e 's/\s*#.*//' | grep -v '^\s*$'
 }
@@ -61,7 +70,7 @@ echo ${TEMP_PLATFORM} >> ${TEMP_INC}
 declutter_file extra/artifacts/_common.inc >> ${TEMP_INC}
 declutter_file extra/artifacts/$ARTIFACT.inc >> ${TEMP_INC}
 for variant in $INCLUDED_VARIANTS ; do
-	echo "::info::\`${variant}\`"
+	echo "- ${variant}"
 	echo "variants/${variant}/" >> ${TEMP_INC}
 	ls firmwares/zephyr-${variant}.* >> ${TEMP_INC}
 done
@@ -78,4 +87,4 @@ tar -cjhf ${OUTPUT_FILE} -X ${TEMP_EXC} -T ${TEMP_INC} \
 	--transform "s,^,ArduinoCore-zephyr/,"
 rm -f ${TEMP_INC} ${TEMP_EXC} ${TEMP_BOARDS} ${TEMP_PLATFORM}
 
-[ -n $GITHUB_WORKSPACE ] && echo "::endgroup::"
+log_msg endgroup