Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make redirectUrl nullable in providers #268

Open
egorksv opened this issue Feb 5, 2025 · 1 comment
Open

Make redirectUrl nullable in providers #268

egorksv opened this issue Feb 5, 2025 · 1 comment

Comments

@egorksv
Copy link

egorksv commented Feb 5, 2025

Our case: we have a multitenantend app which can be accessed on different domains.

Each time we authenticate a user, redirectUrl is calculated based on a tenant ID and their registered domain, which causes typing error.

Our current workaround:

declare module 'arctic' {
  export class KeyCloak {
    constructor(realmURL: string, clientId: string, clientSecret: string | null, redirectURI: string | null);
  }
}

This works fine, but would be nice if arctic supported this out of the box

PS: Also realised this is a bit more involved, at this point we're using pnpm patch to sneak in validateAuthorizationCodeWithRedirectUri function to oauth client and keycloak provider, would you be interested in pull request?

@pilcrowonpaper
Copy link
Owner

Is this issue specifically for Keycloak?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants