-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: role "group" on buttons #417
Comments
@gp-slick-coder, do you recommend updating the docs? Or removing the feature (not possible now to avoid a breaking change). I guess it could be useful for a group of related actions, like: |
Sorry for my bad description. The feature is useful. The only issue is with the focus of the button(s). Current behavior: On a button click, all buttons will be "focused" (as shown in the previous image). Expected behavior: On a button click, only the button that was clicked, should be focused. Good examples: |
What about something like this where the whole border of the button in the group is shown instead of a broken border? CleanShot.2024-02-17.at.01.40.44.mp4Example from: |
The issue with the button group overflowing seems to be due to this style rule setting a new horizontal padding of 2rem, which overrides the original horizontal padding of 1rem. [role=group] [role=button], [role=group] [type=button], [role=group] [type=submit], [role=group] button, [role=search] [role=button], [role=search] [type=button], [role=search] [type=submit], [role=search] button {
--pico-form-element-spacing-horizontal: 2rem;
} It seems that keeping the padding at 1rem still looks decent while allowing the display to get as small as 306px (smaller than an iPhone SE at 375px) without any overflow issues. See attached screen recording Recording.2024-02-18.162102.mp4 |
I'm not so sure if this is useful. This is totally against good UX.
The text was updated successfully, but these errors were encountered: