Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Interface locks up after being up open for a long time. #2424

Open
amirHizkiya opened this issue Nov 8, 2022 · 7 comments · Fixed by #3019
Open

Web Interface locks up after being up open for a long time. #2424

amirHizkiya opened this issue Nov 8, 2022 · 7 comments · Fixed by #3019

Comments

@amirHizkiya
Copy link

Versions

  • Pi-hole: 5.12.2
  • AdminLTE: 5.15.1
  • FTL: 5.18.1

Platform

  • OS and version: Win11
  • Platform: Raspberry Pi

Expected behavior

After having the Web UI open for a while (A few days?) I click on disable blocking -> 5 min. I'm hoping that the Blocking gets disabled.

Actual behavior / bug

What actually happens (After the UI is open a while). Clicking on Disable Blocking ->For 5 Minutes. The spinner shows, but it doesn't spin. I need to actually refresh the page to actually be able to disable blocking

Steps to reproduce

Steps to reproduce the behavior:

  1. Open Web Interface and leave open for a few hours (1 day?)
  2. Click on Disable Blocking -> For 5 Minutes
  3. See error: Spinner shows but doesn't spin. Doesn't actually disable blocking.

Additional context

Super low priority, bit this has been present for quite a few versions. Ill confirm that it shows up in the newest version.

@rdwebdesign
Copy link
Member

Thanks for the report.
I can confirm the behavior.

This happens because the session has expired (after the UI is open for a long time), but there is no response when you click the button.

Note:
As you said, it's low priority.
This is not a security issue, as the button only works if the session is active, but I think it can be a bit annoying for those who often leave the page open in their browser.

@amirHizkiya
Copy link
Author

Great! I just wanted to make sure that it was logged.

It is a little annoying, but I'm sure there are bigger issues to tackle.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Dec 9, 2022
@amirHizkiya
Copy link
Author

This is still a thing, and I didn't want it to be auto-closed.

@rdwebdesign rdwebdesign added never-stale Avoid stale action and removed stale Bug: Confirmed labels Dec 9, 2022
@amirHizkiya
Copy link
Author

Any chance to sneak this into v6?

@rdwebdesign
Copy link
Member

v6 doesn't use PHP to handle sessions.

In v6, this won't happen because the web interface will show the login page when session is expired.

@amirHizkiya
Copy link
Author

Amazing! Thx.

@PromoFaux PromoFaux linked a pull request May 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants