Skip to content

Commit 13b7818

Browse files
Staacksclaude
andcommitted
Mark graph-output-data-picker as fixed: iOS implements the data picker
iOS (development) now reads the graph output tags as the data picker - axis (x/xcal/y/ycal/z/zcal), label and the graph's pickLabel - and the superseded calibrationMode/calibrationParameter draft has been removed from its parser and UI. Accordingly: - inconsistencies.yml: graph-output-data-picker decided -> fixed, iOS observation updated; the cross-reference in ios-behind-on-format-1-20 no longer lists the picker as missing. - spec/views.yml: axis, label and pickLabel are now agreement: agreed; the deprecated calibrationMode and calibrationParameter entries are removed since no implementation reads them anymore. Verified against the iOS handlers with tools/spec_vs_ios.py (no declared attribute missing from the spec). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178m4AqebmTvAz54AgWHXbi
1 parent 4af7dae commit 13b7818

2 files changed

Lines changed: 19 additions & 48 deletions

File tree

inconsistencies.yml

Lines changed: 16 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,7 @@
670670
- id: graph-output-data-picker
671671
title: The output element of a graph means different things on the two apps
672672
area: file-format
673-
status: decided
673+
status: fixed
674674
canonical: >-
675675
The data picker. A graph's output tags configure the data picker introduced
676676
in file format 1.20: each carries axis (x, xcal, y, ycal, z, zcal) and a
@@ -686,23 +686,18 @@
686686
carrying a label; DataOutput has a label field for exactly this
687687
(PhyphoxFile.java, viewBlockParser; ExpView.graphElement.setPickConfig).
688688
ios: >-
689-
Does not implement the data picker at all. Its graph output handler reads
690-
only calibrationParameter, and reads it with the required-attribute
691-
accessor - so an output tag written for the data picker throws
692-
missingAttribute and the whole experiment fails to parse, rather than the
693-
picker simply being unavailable
694-
(GraphViewElementHandler.swift, GraphOutputElementHandler).
689+
Implements the data picker on the development branch since 2026-08: the
690+
graph output handler reads axis and label, pickLabel renames the pick
691+
tool, and the calibrationMode/calibrationParameter draft has been removed
692+
(GraphViewElementHandler.swift, GraphOutputElementHandler,
693+
ExperimentGraphView.swift).
695694
summary: >-
696-
Both apps accept an output tag inside a graph and neither can read the
697-
other's. Android uses it for the data picker; iOS uses it for a superseded
698-
calibration draft whose calibrationParameter attribute is mandatory, so a
699-
data-picker graph does not merely lose the feature on iOS - it stops the file
700-
loading. In practice the version gate hides this today: the data picker
701-
arrived in file format 1.20, iOS supports up to 1.19, so such a file is
702-
refused with the normal "update the app" message. The sharp edge is a file
703-
that declares an older version and uses the construct anyway, which fails
704-
with a confusing parse error instead. Implementing the picker on iOS and
705-
dropping the calibration attributes resolves both.
695+
Both apps accepted an output tag inside a graph and neither could read the
696+
other's. Android used it for the data picker; iOS used it for a superseded
697+
calibration draft whose calibrationParameter attribute was mandatory, so a
698+
data-picker graph did not merely lose the feature on iOS - it stopped the
699+
file loading. iOS now implements the data picker and the calibration draft
700+
is gone; this entry stays until the release carrying the fix has shipped.
706701
707702
- id: ble-address-ios-must-reject
708703
title: The BLE address attribute is Android-only, and iOS should say so
@@ -810,10 +805,10 @@
810805
element, its input child and three parameters. And clearGroup, the attribute
811806
that exempts calibration data from the trash button, is unread on iOS, so the
812807
feature is absent in the app and not only over the remote interface; its
813-
API half is tracked as control-clear-groups. The data picker is the remaining
814-
1.20 feature missing on iOS and is tracked separately as
815-
graph-output-data-picker, because it fails even on a file declaring an older
816-
version.
808+
API half is tracked as control-clear-groups. The data picker was tracked
809+
separately as graph-output-data-picker, because it failed even on a file
810+
declaring an older version; it has since been implemented on the iOS
811+
development branch and that entry is now marked fixed.
817812
818813
- id: ios-hyperbolic-modules-compute-trig
819814
title: sinh, cosh and tanh compute sin, cos and tan on iOS

spec/views.yml

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -801,16 +801,6 @@ elements:
801801
since: "1.20"
802802
agreement: divergent
803803
inconsistency: ios-behind-on-format-1-20
804-
- name: calibrationMode
805-
type: string
806-
values: [xLinear]
807-
deprecated: true
808-
superseded_by: the data picker, configured by the graph's output tags
809-
summary: >-
810-
Draft of a guided calibration workflow, written for the spectroscopy
811-
feature and since replaced. Not part of the format going forward.
812-
agreement: divergent
813-
inconsistency: graph-output-data-picker
814804
- name: pickLabel
815805
description: >-
816806
Rename the "Pick data" button to show to the user the
@@ -822,8 +812,7 @@ elements:
822812
summary: >-
823813
Renames the "Pick data" button, to say what picking is for. Part of the
824814
data picker, configured by the graph's output tags.
825-
agreement: divergent
826-
inconsistency: graph-output-data-picker
815+
agreement: agreed
827816

828817
- name: input
829818
parent: graph
@@ -872,25 +861,12 @@ elements:
872861
immediately, the user is prompted for a value, the point's coordinate
873862
goes to the plain output and the entered value to the `cal` one. That
874863
is how two points are mapped to reference values for a calibration.
875-
agreement: divergent
876-
inconsistency: graph-output-data-picker
864+
agreement: agreed
877865
- name: label
878866
type: string
879867
translatable: true
880868
summary: Text of the button offered for this output once a point is picked.
881-
agreement: divergent
882-
inconsistency: graph-output-data-picker
883-
- name: calibrationParameter
884-
type: enum
885-
values: [slope, intercept]
886-
deprecated: true
887-
superseded_by: the axis attribute of this element
888-
summary: >-
889-
Part of the superseded calibration draft. Required by iOS on every
890-
graph output, which is what makes the two readings of this element
891-
incompatible.
892-
agreement: divergent
893-
inconsistency: graph-output-data-picker
869+
agreement: agreed
894870

895871
# ------------------------------------------------------------------- edit --
896872
- name: edit

0 commit comments

Comments
 (0)