Skip to content

Commit e8fdbcd

Browse files
Staacksclaude
andcommitted
autoConfirm: bypass exactly the three notices the test matrix names.
Aligned with the measured iOS semantics of -phyphoxAutoConfirm and with the switch-bypassed-ui row: the network privacy notice, the photosensitivity warning, and the offer to save a downloaded experiment locally, which counts as declined. The Android-only vendor sensor warning is no longer bypassed - that row pins each bypassed dialog for a UI test without the switch, and a dialog outside it should not be silently skipped. No system permission dialog and no choice with alternatives is touched either way. The network fixtures still pass on an emulator, so the notice that actually gates them is unaffected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 4beb481 commit e8fdbcd

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

app/src/main/java/de/rwth_aachen/phyphox/helper/DebugSwitches.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,14 @@
1919
// host script does not have to discover which port was picked.
2020
// iOS: -phyphoxRemotePort.
2121
// debug.phyphox.autoConfirm confirms the notices an experiment shows when it opens - the
22-
// network privacy warning, the vendor sensor warning, the
23-
// photosensitivity warning - and declines the offer to save a
24-
// downloaded experiment locally. They are informational (their only
25-
// action is OK), but unattended they stall the run: the network
26-
// privacy notice in particular gates the connection setup, so the
27-
// network fixture experiments cannot run without this. It skips no
22+
// network privacy warning and the photosensitivity warning - and
23+
// declines the offer to save a downloaded experiment locally. They
24+
// are informational (their only action is OK), but unattended they
25+
// stall the run: the network privacy notice in particular gates the
26+
// connection setup, so the network fixture experiments cannot run
27+
// without this. Exactly those three, the same set as iOS's
28+
// -phyphoxAutoConfirm and the switch-bypassed-ui test row; the
29+
// Android-only vendor sensor warning is not bypassed. It skips no
2830
// user choice and no system permission dialog, which the app cannot
2931
// dismiss anyway. iOS: -phyphoxAutoConfirm.
3032
//

0 commit comments

Comments
 (0)