Skip to content

Commit dcb047b

Browse files
Staacksclaude
andcommitted
graph-snapshots and the T1 suites run on a tablet profile too.
The chrome row asks for tablet layouts, and a tablet is a second emulator profile rather than a test that resizes the device under itself: the job now runs the instrumented suites twice, on a phone and on a 10.1" tablet. For that the graph goldens had to become per device class - the same graph is a different image at 2560x1600 - so the suite keys them by the sw600dp boundary the layouts themselves use, and light-tablet.png now sits next to light-phone.png. 72 goldens. Recorded and verified on both: the tablet goldens on a tablet AVD, the phone goldens unchanged afterwards, and the whole instrumented suite - 21 tests - green on the tablet as well as on the phone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 5195348 commit dcb047b

38 files changed

Lines changed: 29 additions & 3 deletions

.github/workflows/t1.yml

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,18 @@ jobs:
125125
view-and-chrome-suites:
126126
runs-on: ubuntu-latest
127127
timeout-minutes: 90
128+
strategy:
129+
fail-fast: false
130+
matrix:
131+
#Two device profiles, because the layouts differ across the sw600dp boundary and the
132+
#graph goldens are recorded per device class. The tablet run is not a copy of the phone
133+
#run: it is where a tablet-only layout regression shows up.
134+
include:
135+
- profile: pixel_6
136+
device: phone
137+
- profile: 10.1in WXGA (Tablet)
138+
device: tablet
139+
name: view-and-chrome-suites (${{ matrix.device }})
128140
steps:
129141
- uses: actions/checkout@v5
130142
with:
@@ -157,14 +169,15 @@ jobs:
157169
api-level: ${{ env.API_LEVEL }}
158170
arch: ${{ env.EMULATOR_ARCH }}
159171
target: ${{ env.EMULATOR_TARGET }}
172+
profile: ${{ matrix.profile }}
160173
ram-size: 4096M
161174
script: |
162175
sh phyphox-android/tools/t1_instrumented.sh phyphox-android
163176
- name: Keep the device log and the captured screens
164177
if: always()
165178
uses: actions/upload-artifact@v4
166179
with:
167-
name: t1-instrumented-logs
180+
name: t1-instrumented-logs-${{ matrix.device }}
168181
path: |
169182
logcat-instrumented*.txt
170183
instrumented-*.txt
30 KB
Loading
29.7 KB
Loading
18.8 KB
Loading
17.1 KB
Loading
17 KB
Loading
15.2 KB
Loading
23.4 KB
Loading
21.7 KB
Loading
22.7 KB
Loading

0 commit comments

Comments
 (0)