Commit c106fa1
requireFill: exempt the first run that happened, not the first clock tick.
The gate skipped the analysis block when the observed container held too
little, except on the first run - and "first run" was read off lastAnalysis,
which holds the experiment time. That is exactly zero as long as an
experiment has never been started, so before the first start every pass
counted as the first one and the gate never engaged; the golden vector for
the ruled semantics (spec/analysis.yml requireFill, decided 2026-08-24) is
pinned in precisely that state and saw the block run twice.
A pass that actually ran now sets analysisRan, and stopAllIO clears it again
so the first run after the next start stays exempt. While measuring nothing
changes: the experiment time was non-zero there, so the old test agreed with
the new one. Before the first start, analysis on user input is now gated
from the second pass on, which is what the rule says.
The vector runs unskipped again: 117 of 117.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent af41209 commit c106fa1
2 files changed
Lines changed: 4 additions & 23 deletions
File tree
- app/src
- main/java/de/rwth_aachen/phyphox
- test/java/de/rwth_aachen/phyphox
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
127 | 128 | | |
128 | 129 | | |
129 | 130 | | |
| |||
327 | 328 | | |
328 | 329 | | |
329 | 330 | | |
330 | | - | |
| 331 | + | |
331 | 332 | | |
332 | 333 | | |
333 | 334 | | |
| |||
392 | 393 | | |
393 | 394 | | |
394 | 395 | | |
| 396 | + | |
395 | 397 | | |
396 | 398 | | |
397 | 399 | | |
| |||
441 | 443 | | |
442 | 444 | | |
443 | 445 | | |
| 446 | + | |
444 | 447 | | |
445 | 448 | | |
446 | 449 | | |
| |||
Lines changed: 0 additions & 22 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | 44 | | |
63 | 45 | | |
64 | 46 | | |
| |||
97 | 79 | | |
98 | 80 | | |
99 | 81 | | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | 82 | | |
105 | 83 | | |
106 | 84 | | |
| |||
0 commit comments