Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 8ad5985

Browse files
committed
Fix is_wasm and is_module ScriptOriginOptions handling
1 parent 500c855 commit 8ad5985

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/php_v8_script_origin.cc

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ v8::ScriptOrigin *php_v8_create_script_origin_from_zval(zval *value, v8::Isolate
7474
v8::Local<v8::Integer> script_id = v8::Local<v8::Integer>();
7575
v8::Local<v8::Value> source_map_url = v8::Local<v8::Value>();
7676
v8::Local<v8::Boolean> resource_is_opaque = v8::Local<v8::Boolean>();
77+
v8::Local<v8::Boolean> is_wasm = v8::Local<v8::Boolean>();
78+
v8::Local<v8::Boolean> is_module = v8::Local<v8::Boolean>();
7779

7880
zval *resource_name_zv = zend_read_property(this_ce, value, ZEND_STRL("resource_name"), 0, &rv); // string
7981

@@ -123,9 +125,13 @@ v8::ScriptOrigin *php_v8_create_script_origin_from_zval(zval *value, v8::Isolate
123125
if (Z_TYPE_P(options_zv) == IS_OBJECT) {
124126
zval *is_shared_cross_origin_zv = zend_read_property(php_v8_script_origin_options_class_entry, options_zv, ZEND_STRL("is_shared_cross_origin"), 0, &rv);
125127
zval *is_opaque_zv = zend_read_property(php_v8_script_origin_options_class_entry, options_zv, ZEND_STRL("is_opaque"), 0, &rv);
128+
zval *is_wasm_zv = zend_read_property(php_v8_script_origin_options_class_entry, options_zv, ZEND_STRL("is_wasm"), 0, &rv);
129+
zval *is_module_zv = zend_read_property(php_v8_script_origin_options_class_entry, options_zv, ZEND_STRL("is_module"), 0, &rv);
126130

127131
resource_is_shared_cross_origin = v8::Boolean::New(isolate, Z_TYPE_P(is_shared_cross_origin_zv) == IS_TRUE);
128132
resource_is_opaque = v8::Boolean::New(isolate, Z_TYPE_P(is_opaque_zv) == IS_TRUE);
133+
is_wasm = v8::Boolean::New(isolate, Z_TYPE_P(is_wasm_zv) == IS_TRUE);
134+
is_module = v8::Boolean::New(isolate, Z_TYPE_P(is_module_zv) == IS_TRUE);
129135
}
130136

131137
return new v8::ScriptOrigin(resource_name,
@@ -134,7 +140,9 @@ v8::ScriptOrigin *php_v8_create_script_origin_from_zval(zval *value, v8::Isolate
134140
resource_is_shared_cross_origin,
135141
script_id,
136142
source_map_url,
137-
resource_is_opaque);
143+
resource_is_opaque,
144+
is_wasm,
145+
is_module);
138146
}
139147

140148
static PHP_METHOD(V8ScriptOrigin, __construct) {

0 commit comments

Comments
 (0)