Drop Phing for Makefile, migrate PHPUnit config, update PHPCS config (#160)

Author: Kocal

.gitattributes

@@ -1,10 +1,12 @@
 *.php text eol=lf
 
 tests export-ignore
+tmp export-ignore
 .coveralls.yml export-ignore
 .gitattributes export-ignore
 .gitignore export-ignore
 .travis.yml export-ignore
-build.xml export-ignore
+Makefile export-ignore
 phpcs.xml export-ignore
 phpstan.neon export-ignore
+phpunit.xml export-ignore

.github/workflows/build.yml

@@ -44,7 +44,7 @@ jobs:
 
 
       - name: "Lint"
-        run: "vendor/bin/phing lint"
+        run: "make lint"
 
   coding-standards:
     name: "Coding Standard"
@@ -68,10 +68,10 @@ jobs:
         run: "composer install --no-interaction --no-progress --no-suggest"
 
       - name: "Lint"
-        run: "vendor/bin/phing lint"
+        run: "make lint"
 
       - name: "Coding Standard"
-        run: "vendor/bin/phing cs"
+        run: "make cs"
 
   tests:
     name: "Tests"
@@ -116,7 +116,7 @@ jobs:
         run: "composer require --dev phpunit/phpunit:'^9.5' --update-with-dependencies"
 
       - name: "Tests"
-        run: "vendor/bin/phing tests"
+        run: "make tests"
 
   static-analysis:
     name: "PHPStan"
@@ -160,4 +160,4 @@ jobs:
         run: "composer require --dev phpunit/phpunit:'^9.5' --update-with-dependencies"
 
       - name: "PHPStan"
-        run: "vendor/bin/phing phpstan"
+        run: "make phpstan"

.gitignore

@@ -1,3 +1,4 @@
 /tests/tmp
 /vendor
 composer.lock
+.phpunit.result.cache

Makefile

@@ -0,0 +1,23 @@
+.PHONY: check
+check: lint cs tests phpstan
+
+.PHONY: tests
+tests:
+	php vendor/bin/phpunit
+
+.PHONY: lint
+lint:
+	php vendor/bin/parallel-lint --colors \
+		src tests
+
+.PHONY: cs
+cs:
+	composer install --working-dir build-cs && php build-cs/vendor/bin/phpcs
+
+.PHONY: cs-fix
+cs-fix:
+	php build-cs/vendor/bin/phpcbf
+
+.PHONY: phpstan
+phpstan:
+	php vendor/bin/phpstan analyse -l 8 -c phpstan.neon src tests

build.xml

@@ -21,7 +21,6 @@
     "symfony/framework-bundle": "<3.0"
   },
   "require-dev": {
-    "phing/phing": "^2.16.3",
     "php-parallel-lint/php-parallel-lint": "^1.2",
     "phpstan/phpstan-phpunit": "^0.12.16",
     "phpstan/phpstan-strict-rules": "^0.12.5",
@@ -35,8 +34,8 @@
   },
   "config": {
     "platform": {
-	  "php": "7.4.6"
-	},
+      "php": "7.4.6"
+    },
     "sort-packages": true
   },
   "extra": {

composer.json

@@ -1,5 +1,13 @@
 <?xml version="1.0"?>
 <ruleset name="PHPStan PHPUnit extensions and rules">
+    <arg name="colors"/>
+    <arg name="extensions" value="php"/>
+    <arg name="encoding" value="utf-8"/>
+    <arg name="tab-width" value="4"/>
+    <arg name="cache" value="tmp/cache/phpcs"/>
+    <arg value="sp"/>
+    <file>src</file>
+    <file>tests</file>
     <rule ref="build-cs/vendor/consistence-community/coding-standard/Consistence/ruleset.xml">
         <exclude name="Squiz.Functions.GlobalFunction.Found"/>
         <exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameAfterKeyword"/>

phpcs.xml

@@ -0,0 +1,36 @@
+<?xml version="1.0"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         bootstrap="tests/bootstrap.php"
+         colors="true"
+         backupGlobals="false"
+         backupStaticAttributes="false"
+         beStrictAboutChangesToGlobalState="true"
+         beStrictAboutOutputDuringTests="true"
+         beStrictAboutTestsThatDoNotTestAnything="true"
+         beStrictAboutTodoAnnotatedTests="true"
+         failOnRisky="true"
+         failOnWarning="true"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
+>
+    <coverage>
+        <include>
+            <directory suffix=".php">./src</directory>
+        </include>
+        <report>
+            <clover outputFile="tests/tmp/clover.xml"/>
+            <text
+                outputFile="php://stdout"
+                showUncoveredFiles="true"
+                showOnlySummary="true"
+            />
+        </report>
+    </coverage>
+
+    <testsuites>
+        <testsuite name="PHPStan for Symfony">
+            <directory suffix="Test.php">tests</directory>
+        </testsuite>
+    </testsuites>
+
+    <logging/>
+</phpunit>

phpunit.xml

@@ -0,0 +1,3 @@
+*
+!cache
+!.*

tests/phpunit.xml

@@ -0,0 +1,2 @@
+*
+!.*