Skip to content

Add PhpVersion::__construct to BC promise #8582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
janedbal opened this issue Dec 23, 2022 · 1 comment · May be fixed by phpstan/phpstan-src#4022
Open

Add PhpVersion::__construct to BC promise #8582

janedbal opened this issue Dec 23, 2022 · 1 comment · May be fixed by phpstan/phpstan-src#4022
Labels
feature-request

Comments

@janedbal
Copy link
Contributor

Bug report

Doing new PhpVersion(80_000) causes Creating new PHPStan\Php\PhpVersion is not covered by backward compatibility promise. The class might change in a minor PHPStan version., but I think it should be preferred way to test different PHP versions in PHPStan rules tests. Like here.

Code snippet that reproduces the problem

new PhpVersion(80_000);

Expected output

No error produced
@mergeable
Copy link

mergeable bot commented Dec 23, 2022

This bug report is missing a link to reproduction at phpstan.org/try.

It will most likely be closed after manual review.

@VincentLanglet VincentLanglet linked a pull request May 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PHPVersion::__construct to api VincentLanglet/phpstan-src
2 participants
@ondrejmirtes @janedbal