Resolve Static throw points

Author: VincentLanglet

src/Analyser/NodeScopeResolver.php

@@ -4260,6 +4260,18 @@ private function getMethodThrowPoint(MethodReflection $methodReflection, Paramet
 
 		if ($throwType !== null) {
 			if (!$throwType->isVoid()->yes()) {
+				if ($throwType instanceof StaticType) {
+					$classReflections = $scope->getType($methodCall->var)->getObjectClassReflections();
+					if (count($classReflections) > 0) {
+						$types = [];
+						foreach ($classReflections as $classReflection) {
+							$types[] = $throwType->changeBaseClass($classReflection);
+						}
+
+						$throwType = TypeCombinator::union(...$types);
+					}
+				}
+
 				return ThrowPoint::createExplicit($scope, $throwType, $methodCall, true);
 			}
 		} elseif ($this->implicitThrows) {
@@ -4297,6 +4309,10 @@ private function getConstructorThrowPoint(MethodReflection $constructorReflectio
 		if ($constructorReflection->getThrowType() !== null) {
 			$throwType = $constructorReflection->getThrowType();
 			if (!$throwType->isVoid()->yes()) {
+				if ($throwType instanceof StaticType && $this->reflectionProvider->hasClass($className->name)) {
+					$throwType = $throwType->changeBaseClass($this->reflectionProvider->getClass($className->name));
+				}
+
 				return ThrowPoint::createExplicit($scope, $throwType, $new, true);
 			}
 		} elseif ($this->implicitThrows) {
@@ -4329,6 +4345,25 @@ private function getStaticMethodThrowPoint(MethodReflection $methodReflection, P
 		if ($methodReflection->getThrowType() !== null) {
 			$throwType = $methodReflection->getThrowType();
 			if (!$throwType->isVoid()->yes()) {
+				if ($throwType instanceof StaticType) {
+					if ($methodCall->class instanceof Name) {
+						if ($this->reflectionProvider->hasClass($methodCall->class->name)) {
+							$throwType = $throwType->changeBaseClass($this->reflectionProvider->getClass($methodCall->class->name));
+						}
+					} else {
+						$classReflections = $scope->getType($methodCall->class)->getObjectClassReflections();
+
+						if (count($classReflections) > 0) {
+							$types = [];
+							foreach ($classReflections as $classReflection) {
+								$types[] = $throwType->changeBaseClass($classReflection);
+							}
+
+							$throwType = TypeCombinator::union(...$types);
+						}
+					}
+				}
+
 				return ThrowPoint::createExplicit($scope, $throwType, $methodCall, true);
 			}
 		} elseif ($this->implicitThrows) {
@@ -4409,6 +4444,18 @@ private function getThrowPointsFromPropertyHook(
 
 		if ($throwType !== null) {
 			if (!$throwType->isVoid()->yes()) {
+				if ($throwType instanceof StaticType) {
+					$classReflections = $scope->getType($propertyFetch->var)->getObjectClassReflections();
+					if (count($classReflections) > 0) {
+						$types = [];
+						foreach ($classReflections as $classReflection) {
+							$types[] = $throwType->changeBaseClass($classReflection);
+						}
+
+						$throwType = TypeCombinator::union(...$types);
+					}
+				}
+
 				return [ThrowPoint::createExplicit($scope, $throwType, $propertyFetch, true)];
 			}
 		} elseif ($this->implicitThrows) {

tests/PHPStan/Rules/Exceptions/Bug11900Test.php

@@ -0,0 +1,43 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Exceptions;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<MissingCheckedExceptionInMethodThrowsRule>
+ */
+class Bug11900Test extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new MissingCheckedExceptionInMethodThrowsRule(
+			new MissingCheckedExceptionInThrowsCheck(new DefaultExceptionTypeResolver(
+				self::createReflectionProvider(),
+				[],
+				[],
+				[],
+				[],
+			)),
+		);
+	}
+
+	public function testRule(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+            self::markTestSkipped('Test requires PHP 8.4.');
+        }
+
+		$this->analyse([__DIR__ . '/data/bug-11900.php'], []);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/bug-11900.neon',
+		];
+	}
+
+}

tests/PHPStan/Rules/Exceptions/bug-11900.neon

@@ -0,0 +1,6 @@
+parameters:
+    exceptions:
+        implicitThrows: false
+        check:
+            missingCheckedExceptionInThrows: true
+            tooWideThrowType: true

tests/PHPStan/Rules/Exceptions/data/bug-11900.php

@@ -0,0 +1,87 @@
+<?php // lint >= 8.4
+
+namespace Bug11900;
+
+use Exception;
+use Throwable;
+
+abstract class ADataException extends Exception
+{
+	public int $i {
+		/** @throws static */
+		get {
+			if (rand(0, 1)) {
+				throw new static();
+			}
+
+			return 42;
+		}
+	}
+
+	/** @throws static */
+	public function __construct(string $message = "", int $code = 0, ?Throwable $previous = null)
+	{
+		if (rand(0, 1)) {
+			throw new static();
+		}
+
+		parent::__construct($message, $code, $previous);
+	}
+
+	/**
+	 * @return void
+	 * @throws static
+	 */
+	public function throw1(): void
+	{
+		throw $this;
+	}
+
+	/**
+	 * @return void
+	 * @throws static
+	 */
+	public static function throw2(): void
+	{
+		throw new static();
+	}
+}
+
+final class TestDataException extends ADataException
+{
+}
+
+class TestPhpStan
+{
+	/**
+	 * @throws TestDataException
+	 */
+	public function validate(TestDataException $e): void
+	{
+		$e->throw1();
+	}
+
+	/**
+	 * @throws TestDataException
+	 */
+	public function validate2(): void
+	{
+		TestDataException::throw2();
+	}
+
+	/**
+	 * @throws TestDataException
+	 */
+	public function validate3(TestDataException $e): void
+	{
+		$e->i;
+	}
+
+	/**
+	 * @throws TestDataException
+	 */
+	public function validate4(): void
+	{
+		new TestDataException();
+	}
+}