Use Stubs instead of Mocks

staabm · staabm · commit 1b71b5134099 · 2025-12-09T21:43:13.000+01:00
No expectations were configured for the mock object for PHPStan\Analyser\Scope. You should refactor your test code and use a test stub instead.
diff --git a/tests/PHPStan/Command/AnalyseApplicationIntegrationTest.php b/tests/PHPStan/Command/AnalyseApplicationIntegrationTest.php
@@ -62,7 +62,7 @@ private function runPath(string $path, int $expectedStatusCode): string
 
 		$symfonyOutput = new SymfonyOutput(
 			$output,
-			new \PHPStan\Command\Symfony\SymfonyStyle(new SymfonyStyle($this->createMock(InputInterface::class), $output)),
+			new \PHPStan\Command\Symfony\SymfonyStyle(new SymfonyStyle($this->createStub(InputInterface::class), $output)),
 		);
 
 		$relativePathHelper = new FuzzyRelativePathHelper(new NullRelativePathHelper(), __DIR__, [], DIRECTORY_SEPARATOR);
@@ -88,7 +88,7 @@ private function runPath(string $path, int $expectedStatusCode): string
 			null,
 			null,
 			null,
-			$this->createMock(InputInterface::class),
+			$this->createStub(InputInterface::class),
 		);
 		$statusCode = $errorFormatter->formatErrors($analysisResult, $symfonyOutput);
 
diff --git a/tests/PHPStan/Parser/CachedParserTest.php b/tests/PHPStan/Parser/CachedParserTest.php
@@ -10,6 +10,7 @@
 use PHPStan\Testing\PHPStanTestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\MockObject\Stub;
 
 class CachedParserTest extends PHPStanTestCase
 {
@@ -21,7 +22,7 @@ public function testParseFileClearCache(
 	): void
 	{
 		$parser = new CachedParser(
-			$this->getParserMock(),
+			$this->getParserStub(),
 			$cachedNodesByStringCountMax,
 		);
 
@@ -62,19 +63,19 @@ public static function dataParseFileClearCache(): Generator
 		];
 	}
 
-	private function getParserMock(): Parser&MockObject
+	private function getParserStub(): Parser&Stub
 	{
-		$mock = $this->createMock(Parser::class);
+		$mock = $this->createStub(Parser::class);
 
-		$mock->method('parseFile')->willReturn([$this->getPhpParserNodeMock()]);
-		$mock->method('parseString')->willReturn([$this->getPhpParserNodeMock()]);
+		$mock->method('parseFile')->willReturn([$this->getPhpParserNodeStub()]);
+		$mock->method('parseString')->willReturn([$this->getPhpParserNodeStub()]);
 
 		return $mock;
 	}
 
-	private function getPhpParserNodeMock(): Node&MockObject
+	private function getPhpParserNodeStub(): Node&Stub
 	{
-		return $this->createMock(Node::class);
+		return $this->createStub(Node::class);
 	}
 
 	public function testParseTheSameFileWithDifferentMethod(): void
diff --git a/tests/PHPStan/Reflection/Annotations/AnnotationsMethodsClassReflectionExtensionTest.php b/tests/PHPStan/Reflection/Annotations/AnnotationsMethodsClassReflectionExtensionTest.php
@@ -966,7 +966,7 @@ public function testMethods(string $className, array $methods): void
 	{
 		$reflectionProvider = self::createReflectionProvider();
 		$class = $reflectionProvider->getClass($className);
-		$scope = $this->createMock(Scope::class);
+		$scope = $this->createStub(Scope::class);
 		$scope->method('isInClass')->willReturn(true);
 		$scope->method('getClassReflection')->willReturn($class);
 		$scope->method('canCallMethod')->willReturn(true);
diff --git a/tests/PHPStan/Reflection/Annotations/AnnotationsPropertiesClassReflectionExtensionTest.php b/tests/PHPStan/Reflection/Annotations/AnnotationsPropertiesClassReflectionExtensionTest.php
@@ -280,7 +280,7 @@ public function testProperties(string $className, array $properties): void
 	{
 		$reflectionProvider = self::createReflectionProvider();
 		$class = $reflectionProvider->getClass($className);
-		$scope = $this->createMock(Scope::class);
+		$scope = $this->createStub(Scope::class);
 		$scope->method('isInClass')->willReturn(true);
 		$scope->method('getClassReflection')->willReturn($class);
 		$scope->method('canAccessProperty')->willReturn(true);
diff --git a/tests/PHPStan/Reflection/Annotations/DeprecatedAnnotationsTest.php b/tests/PHPStan/Reflection/Annotations/DeprecatedAnnotationsTest.php
@@ -101,7 +101,7 @@ public function testDeprecatedAnnotations(bool $deprecated, string $className, ?
 	{
 		$reflectionProvider = self::createReflectionProvider();
 		$class = $reflectionProvider->getClass($className);
-		$scope = $this->createMock(Scope::class);
+		$scope = $this->createStub(Scope::class);
 		$scope->method('isInClass')->willReturn(true);
 		$scope->method('getClassReflection')->willReturn($class);
 		$scope->method('canAccessProperty')->willReturn(true);
diff --git a/tests/PHPStan/Reflection/Annotations/FinalAnnotationsTest.php b/tests/PHPStan/Reflection/Annotations/FinalAnnotationsTest.php
@@ -45,7 +45,7 @@ public function testFinalAnnotations(bool $final, string $className, array $fina
 	{
 		$reflectionProvider = self::createReflectionProvider();
 		$class = $reflectionProvider->getClass($className);
-		$scope = $this->createMock(Scope::class);
+		$scope = $this->createStub(Scope::class);
 		$scope->method('isInClass')->willReturn(true);
 		$scope->method('getClassReflection')->willReturn($class);
 		$scope->method('canAccessProperty')->willReturn(true);
diff --git a/tests/PHPStan/Reflection/Annotations/InternalAnnotationsTest.php b/tests/PHPStan/Reflection/Annotations/InternalAnnotationsTest.php
@@ -126,7 +126,7 @@ public function testInternalAnnotations(bool $internal, string $className, array
 	{
 		$reflectionProvider = self::createReflectionProvider();
 		$class = $reflectionProvider->getClass($className);
-		$scope = $this->createMock(Scope::class);
+		$scope = $this->createStub(Scope::class);
 		$scope->method('isInClass')->willReturn(true);
 		$scope->method('getClassReflection')->willReturn($class);
 		$scope->method('canAccessProperty')->willReturn(true);
diff --git a/tests/PHPStan/Reflection/Annotations/ThrowsAnnotationsTest.php b/tests/PHPStan/Reflection/Annotations/ThrowsAnnotationsTest.php
@@ -76,7 +76,7 @@ public function testThrowsAnnotations(string $className, array $throwsAnnotation
 	{
 		$reflectionProvider = self::createReflectionProvider();
 		$class = $reflectionProvider->getClass($className);
-		$scope = $this->createMock(Scope::class);
+		$scope = $this->createStub(Scope::class);
 
 		foreach ($throwsAnnotations as $methodName => $type) {
 			$methodAnnotation = $class->getMethod($methodName, $scope);
diff --git a/tests/PHPStan/Reflection/FunctionReflectionTest.php b/tests/PHPStan/Reflection/FunctionReflectionTest.php
@@ -119,7 +119,7 @@ public function testMethodHasPhpdoc(string $className, string $methodName, ?stri
 	{
 		$reflectionProvider = self::createReflectionProvider();
 		$class = $reflectionProvider->getClass($className);
-		$scope = $this->createMock(Scope::class);
+		$scope = $this->createStub(Scope::class);
 		$scope->method('isInClass')->willReturn(true);
 		$scope->method('getClassReflection')->willReturn($class);
 		$scope->method('canAccessProperty')->willReturn(true);
@@ -180,7 +180,7 @@ public function testMethodReturnsByReference(string $className, string $methodNa
 	{
 		$reflectionProvider = self::createReflectionProvider();
 		$class = $reflectionProvider->getClass($className);
-		$scope = $this->createMock(Scope::class);
+		$scope = $this->createStub(Scope::class);
 		$scope->method('isInClass')->willReturn(true);
 		$scope->method('getClassReflection')->willReturn($class);
 		$scope->method('canAccessProperty')->willReturn(true);
diff --git a/tests/PHPStan/Reflection/Type/IntersectionTypeMethodReflectionTest.php b/tests/PHPStan/Reflection/Type/IntersectionTypeMethodReflectionTest.php
@@ -38,7 +38,7 @@ public function testMultipleDeprecationsAreJoined(): void
 
 	private function createDeprecatedMethod(TrinaryLogic $deprecated, ?string $deprecationText): ExtendedMethodReflection
 	{
-		$method = $this->createMock(ExtendedMethodReflection::class);
+		$method = $this->createStub(ExtendedMethodReflection::class);
 		$method->method('isDeprecated')->willReturn($deprecated);
 		$method->method('getDeprecatedDescription')->willReturn($deprecationText);
 		return $method;
diff --git a/tests/PHPStan/Reflection/Type/UnionTypeMethodReflectionTest.php b/tests/PHPStan/Reflection/Type/UnionTypeMethodReflectionTest.php
@@ -38,7 +38,7 @@ public function testMultipleDeprecationsAreJoined(): void
 
 	private function createDeprecatedMethod(TrinaryLogic $deprecated, ?string $deprecationText): ExtendedMethodReflection
 	{
-		$method = $this->createMock(ExtendedMethodReflection::class);
+		$method = $this->createStub(ExtendedMethodReflection::class);
 		$method->method('isDeprecated')->willReturn($deprecated);
 		$method->method('getDeprecatedDescription')->willReturn($deprecationText);
 		return $method;
diff --git a/tests/PHPStan/Rules/Api/ApiRuleHelperTest.php b/tests/PHPStan/Rules/Api/ApiRuleHelperTest.php
@@ -144,7 +144,7 @@ public function testIsPhpStanCode(
 	): void
 	{
 		$rule = new ApiRuleHelper();
-		$scope = $this->createMock(Scope::class);
+		$scope = $this->createStub(Scope::class);
 		$scope->method('getNamespace')->willReturn($scopeNamespace);
 		$scope->method('getFile')->willReturn($scopeFile);
 		$this->assertSame($expected, $rule->isPhpStanCode($scope, $nameToCheck, $declaringFileNameToCheck));

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`use PHPStan\Testing\PHPStanTestCase;`
`11`	`11`	`use PHPUnit\Framework\Attributes\DataProvider;`
`12`	`12`	`use PHPUnit\Framework\MockObject\MockObject;`
	`13`	`+use PHPUnit\Framework\MockObject\Stub;`
`13`	`14`
`14`	`15`	`class CachedParserTest extends PHPStanTestCase`
`15`	`16`	`{`
`@@ -21,7 +22,7 @@ public function testParseFileClearCache(`
`21`	`22`	`): void`
`22`	`23`	`{`
`23`	`24`	`$parser = new CachedParser(`
`24`		`- $this->getParserMock(),`
	`25`	`+ $this->getParserStub(),`
`25`	`26`	`$cachedNodesByStringCountMax,`
`26`	`27`	`);`
`27`	`28`
`@@ -62,19 +63,19 @@ public static function dataParseFileClearCache(): Generator`
`62`	`63`	`];`
`63`	`64`	`}`
`64`	`65`
`65`		`- private function getParserMock(): Parser&MockObject`
	`66`	`+ private function getParserStub(): Parser&Stub`
`66`	`67`	`{`
`67`		`- $mock = $this->createMock(Parser::class);`
	`68`	`+ $mock = $this->createStub(Parser::class);`
`68`	`69`
`69`		`- $mock->method('parseFile')->willReturn([$this->getPhpParserNodeMock()]);`
`70`		`- $mock->method('parseString')->willReturn([$this->getPhpParserNodeMock()]);`
	`70`	`+ $mock->method('parseFile')->willReturn([$this->getPhpParserNodeStub()]);`
	`71`	`+ $mock->method('parseString')->willReturn([$this->getPhpParserNodeStub()]);`
`71`	`72`
`72`	`73`	`return $mock;`
`73`	`74`	`}`
`74`	`75`
`75`		`- private function getPhpParserNodeMock(): Node&MockObject`
	`76`	`+ private function getPhpParserNodeStub(): Node&Stub`
`76`	`77`	`{`
`77`		`- return $this->createMock(Node::class);`
	`78`	`+ return $this->createStub(Node::class);`
`78`	`79`	`}`
`79`	`80`
`80`	`81`	`public function testParseTheSameFileWithDifferentMethod(): void`
Original file line number	Diff line number	Diff line change
`@@ -966,7 +966,7 @@ public function testMethods(string $className, array $methods): void`
`966`	`966`	`{`
`967`	`967`	`$reflectionProvider = self::createReflectionProvider();`
`968`	`968`	`$class = $reflectionProvider->getClass($className);`
`969`		`- $scope = $this->createMock(Scope::class);`
	`969`	`+ $scope = $this->createStub(Scope::class);`
`970`	`970`	`$scope->method('isInClass')->willReturn(true);`
`971`	`971`	`$scope->method('getClassReflection')->willReturn($class);`
`972`	`972`	`$scope->method('canCallMethod')->willReturn(true);`
Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,7 @@ public function testProperties(string $className, array $properties): void`
`280`	`280`	`{`
`281`	`281`	`$reflectionProvider = self::createReflectionProvider();`
`282`	`282`	`$class = $reflectionProvider->getClass($className);`
`283`		`- $scope = $this->createMock(Scope::class);`
	`283`	`+ $scope = $this->createStub(Scope::class);`
`284`	`284`	`$scope->method('isInClass')->willReturn(true);`
`285`	`285`	`$scope->method('getClassReflection')->willReturn($class);`
`286`	`286`	`$scope->method('canAccessProperty')->willReturn(true);`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public function testDeprecatedAnnotations(bool $deprecated, string $className, ?`
`101`	`101`	`{`
`102`	`102`	`$reflectionProvider = self::createReflectionProvider();`
`103`	`103`	`$class = $reflectionProvider->getClass($className);`
`104`		`- $scope = $this->createMock(Scope::class);`
	`104`	`+ $scope = $this->createStub(Scope::class);`
`105`	`105`	`$scope->method('isInClass')->willReturn(true);`
`106`	`106`	`$scope->method('getClassReflection')->willReturn($class);`
`107`	`107`	`$scope->method('canAccessProperty')->willReturn(true);`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function testFinalAnnotations(bool $final, string $className, array $fina`
`45`	`45`	`{`
`46`	`46`	`$reflectionProvider = self::createReflectionProvider();`
`47`	`47`	`$class = $reflectionProvider->getClass($className);`
`48`		`- $scope = $this->createMock(Scope::class);`
	`48`	`+ $scope = $this->createStub(Scope::class);`
`49`	`49`	`$scope->method('isInClass')->willReturn(true);`
`50`	`50`	`$scope->method('getClassReflection')->willReturn($class);`
`51`	`51`	`$scope->method('canAccessProperty')->willReturn(true);`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public function testInternalAnnotations(bool $internal, string $className, array`
`126`	`126`	`{`
`127`	`127`	`$reflectionProvider = self::createReflectionProvider();`
`128`	`128`	`$class = $reflectionProvider->getClass($className);`
`129`		`- $scope = $this->createMock(Scope::class);`
	`129`	`+ $scope = $this->createStub(Scope::class);`
`130`	`130`	`$scope->method('isInClass')->willReturn(true);`
`131`	`131`	`$scope->method('getClassReflection')->willReturn($class);`
`132`	`132`	`$scope->method('canAccessProperty')->willReturn(true);`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function testThrowsAnnotations(string $className, array $throwsAnnotation`
`76`	`76`	`{`
`77`	`77`	`$reflectionProvider = self::createReflectionProvider();`
`78`	`78`	`$class = $reflectionProvider->getClass($className);`
`79`		`- $scope = $this->createMock(Scope::class);`
	`79`	`+ $scope = $this->createStub(Scope::class);`
`80`	`80`
`81`	`81`	`foreach ($throwsAnnotations as $methodName => $type) {`
`82`	`82`	`$methodAnnotation = $class->getMethod($methodName, $scope);`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function testMultipleDeprecationsAreJoined(): void`
`38`	`38`
`39`	`39`	`private function createDeprecatedMethod(TrinaryLogic $deprecated, ?string $deprecationText): ExtendedMethodReflection`
`40`	`40`	`{`
`41`		`- $method = $this->createMock(ExtendedMethodReflection::class);`
	`41`	`+ $method = $this->createStub(ExtendedMethodReflection::class);`
`42`	`42`	`$method->method('isDeprecated')->willReturn($deprecated);`
`43`	`43`	`$method->method('getDeprecatedDescription')->willReturn($deprecationText);`
`44`	`44`	`return $method;`