First working version

ondrejmirtes · ondrejmirtes · commit c9fd613e9cf7 · 2017-11-11T14:50:16.000+01:00
diff --git a/.editorconfig b/.editorconfig
@@ -0,0 +1,27 @@
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+trim_trailing_whitespace = true
+
+[*.{php,phpt}]
+indent_style = tab
+indent_size = 4
+
+[*.xml]
+indent_style = tab
+indent_size = 4
+
+[*.neon]
+indent_style = tab
+indent_size = 4
+
+[*.{yaml,yml}]
+indent_style = space
+indent_size = 2
+
+[composer.json]
+indent_style = tab
+indent_size = 4
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1 @@
+/tests export-ignore
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,2 @@
+/composer.lock
+/vendor
diff --git a/.travis.yml b/.travis.yml
@@ -0,0 +1,10 @@
+language: php
+php:
+  - 7.0
+  - 7.1
+  - 7.2
+before_script:
+  - composer self-update
+  - composer install
+script:
+  - vendor/bin/phing
diff --git a/README.md b/README.md
@@ -1,2 +1,27 @@
 # PHP-Parser extension for PHPStan
 
+[![Build Status](https://travis-ci.org/phpstan/phpstan-php-parser.svg)](https://travis-ci.org/phpstan/phpstan-php-parser)
+[![Latest Stable Version](https://poser.pugx.org/phpstan/phpstan-php-parser/v/stable)](https://packagist.org/packages/phpstan/phpstan-php-parser)
+[![License](https://poser.pugx.org/phpstan/phpstan-php-parser/license)](https://packagist.org/packages/phpstan/phpstan-php-parser)
+
+* [PHPStan](https://github.com/phpstan/phpstan)
+* [PHP-Parser](https://github.com/nikic/php-parser)
+
+This extension provides the following feature:
+
+* If you register `PhpParser\NodeVisitor\NameResolver` visitor on `PhpParser\NodeTraverser`, new `$namespacedName` property becomes available on nodes that already have a `$name` property. This extension defines that property.
+
+## Usage
+
+To use this extension, require it in [Composer](https://getcomposer.org/):
+
+```
+composer require --dev phpstan/phpstan-php-parser
+```
+
+And include extension.neon in your project's PHPStan config:
+
+```
+includes:
+	- vendor/phpstan/phpstan-php-parser/extension.neon
+```
diff --git a/build.xml b/build.xml
@@ -0,0 +1,101 @@
+<?xml version="1.0" encoding="utf-8"?>
+<project name="PHPStan PHP-Parser extensions" default="check">
+
+	<target name="check" depends="
+		composer,
+		lint,
+		cs,
+		tests,
+		phpstan
+	"/>
+
+	<target name="composer">
+		<exec
+				executable="composer"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="install"/>
+		</exec>
+	</target>
+
+	<target name="lint">
+		<exec
+				executable="vendor/bin/parallel-lint"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="--exclude"/>
+			<arg path="tests/PHPStan/Analyser/data"/>
+			<arg path="src" />
+			<arg path="tests" />
+		</exec>
+	</target>
+
+	<target name="cs">
+		<exec
+				executable="vendor/bin/phpcs"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="--extensions=php"/>
+			<arg value="--encoding=utf-8"/>
+			<arg value="--tab-width=4"/>
+			<arg value="--ignore=tests/*/data"/>
+			<arg value="-sp"/>
+			<arg path="src"/>
+			<arg path="tests"/>
+		</exec>
+	</target>
+
+	<target name="cs-fix">
+		<exec
+				executable="vendor/bin/phpcbf"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="--extensions=php"/>
+			<arg value="--encoding=utf-8"/>
+			<arg value="--tab-width=4"/>
+			<arg value="--ignore=tests/*/data"/>
+			<arg value="-sp"/>
+			<arg path="src"/>
+			<arg path="tests"/>
+		</exec>
+	</target>
+
+	<target name="tests">
+		<exec
+				executable="vendor/bin/phpunit"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="-c"/>
+			<arg value="tests/phpunit.xml"/>
+			<arg path="tests"/>
+		</exec>
+	</target>
+
+	<target name="phpstan">
+		<exec
+				executable="vendor/bin/phpstan"
+				logoutput="true"
+				passthru="true"
+				checkreturn="true"
+		>
+			<arg value="analyse"/>
+			<arg value="-l"/>
+			<arg value="7"/>
+			<arg value="-c"/>
+			<arg path="phpstan.neon"/>
+			<arg path="src"/>
+			<arg path="tests"/>
+		</exec>
+	</target>
+
+</project>
diff --git a/composer.json b/composer.json
@@ -0,0 +1,33 @@
+{
+	"name": "phpstan/phpstan-php-parser",
+	"description": "PHP-Parser extensions for PHPStan",
+	"license": ["MIT"],
+	"minimum-stability": "dev",
+	"prefer-stable": true,
+	"extra": {
+		"branch-alias": {
+			"dev-master": "0.9-dev"
+		}
+	},
+	"require": {
+		"php": "~7.0",
+		"phpstan/phpstan": "^0.9",
+		"nikic/php-parser": "^3.1"
+	},
+	"require-dev": {
+		"consistence/coding-standard": "^2.0.0",
+		"jakub-onderka/php-parallel-lint": "^0.9.2",
+		"phing/phing": "^2.16.0",
+		"phpstan/phpstan-phpunit": "^0.9",
+		"phpunit/phpunit": "^6.4",
+		"slevomat/coding-standard": "^3.3.0"
+	},
+	"autoload": {
+		"psr-4": {
+			"PHPStan\\": "src/"
+		}
+	},
+	"autoload-dev": {
+		"classmap": ["tests/"]
+	}
+}
diff --git a/extension.neon b/extension.neon
@@ -0,0 +1,5 @@
+services:
+	-
+		class: PHPStan\Reflection\PHPParser\PhpParserNameClassReflectionExtension
+		tags:
+			- phpstan.broker.propertiesClassReflectionExtension
diff --git a/phpcs.xml b/phpcs.xml
@@ -0,0 +1,39 @@
+<?xml version="1.0"?>
+<ruleset name="PHPStan">
+	<rule ref="vendor/consistence/coding-standard/Consistence/ruleset.xml">
+		<exclude name="Squiz.Functions.GlobalFunction.Found"/>
+	</rule>
+	<rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/ruleset.xml">
+		<exclude name="SlevomatCodingStandard.Classes.ClassConstantVisibility.MissingConstantVisibility"/>
+		<exclude name="SlevomatCodingStandard.Files.TypeNameMatchesFileName"/>
+		<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameAfterKeyword"/>
+		<exclude name="SlevomatCodingStandard.Namespaces.UseOnlyWhitelistedNamespaces"/>
+		<exclude name="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly"/>
+		<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingTraversableParameterTypeHintSpecification"/>
+		<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingTraversableReturnTypeHintSpecification"/>
+		<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation.NonFullyQualifiedClassName"/>
+		<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalConstants"/>
+		<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalFunctions"/>
+		<exclude name="SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue"/>
+	</rule>
+	<rule ref="SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses">
+		<properties>
+			<property name="caseSensitive" value="false"/>
+		</properties>
+	</rule>
+	<rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
+		<properties>
+			<property name="newlinesCountBetweenOpenTagAndDeclare" value="0"/>
+		</properties>
+	</rule>
+	<rule ref="SlevomatCodingStandard.TypeHints.TypeHintDeclaration">
+		<properties>
+			<property name="usefulAnnotations" type="array" value="
+				@dataProvider,
+				@requires
+			"/>
+			<property name="enableNullableTypeHints" type="false" />
+			<property name="enableVoidTypeHint" type="false" />
+		</properties>
+	</rule>
+</ruleset>
diff --git a/phpstan.neon b/phpstan.neon
@@ -0,0 +1,3 @@
+includes:
+	- vendor/phpstan/phpstan-phpunit/extension.neon
+	- vendor/phpstan/phpstan-phpunit/rules.neon
diff --git a/src/Reflection/PHPParser/NamespacedNameProperty.php b/src/Reflection/PHPParser/NamespacedNameProperty.php
@@ -0,0 +1,56 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Reflection\PHPParser;
+
+use PhpParser\Node\Name;
+use PHPStan\Reflection\ClassReflection;
+use PHPStan\Type\ObjectType;
+use PHPStan\Type\Type;
+
+class NamespacedNameProperty implements \PHPStan\Reflection\PropertyReflection
+{
+
+	/** @var \PHPStan\Reflection\ClassReflection */
+	private $declaringClass;
+
+	public function __construct(ClassReflection $declaringClass)
+	{
+		$this->declaringClass = $declaringClass;
+	}
+
+	public function getDeclaringClass(): ClassReflection
+	{
+		return $this->declaringClass;
+	}
+
+	public function isStatic(): bool
+	{
+		return false;
+	}
+
+	public function isPrivate(): bool
+	{
+		return false;
+	}
+
+	public function isPublic(): bool
+	{
+		return true;
+	}
+
+	public function getType(): Type
+	{
+		return new ObjectType(Name::class);
+	}
+
+	public function isReadable(): bool
+	{
+		return true;
+	}
+
+	public function isWritable(): bool
+	{
+		return true;
+	}
+
+}
diff --git a/src/Reflection/PHPParser/PhpParserNameClassReflectionExtension.php b/src/Reflection/PHPParser/PhpParserNameClassReflectionExtension.php
@@ -0,0 +1,25 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Reflection\PHPParser;
+
+use PhpParser\Node;
+use PHPStan\Reflection\ClassReflection;
+use PHPStan\Reflection\PropertiesClassReflectionExtension;
+use PHPStan\Reflection\PropertyReflection;
+
+class PhpParserNameClassReflectionExtension implements PropertiesClassReflectionExtension
+{
+
+	public function hasProperty(ClassReflection $classReflection, string $propertyName): bool
+	{
+		return $classReflection->isSubclassOf(Node::class)
+			&& ($classReflection->getNativeReflection()->hasProperty('name') || $classReflection->getName() === \PhpParser\Node\FunctionLike::class)
+			&& $propertyName === 'namespacedName';
+	}
+
+	public function getProperty(ClassReflection $classReflection, string $propertyName): PropertyReflection
+	{
+		return new NamespacedNameProperty($classReflection);
+	}
+
+}
diff --git a/tests/Reflection/PHPParser/PhpParserNameClassReflectionExtensionTest.php b/tests/Reflection/PHPParser/PhpParserNameClassReflectionExtensionTest.php
@@ -0,0 +1,57 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Reflection\PHPParser;
+
+class PhpParserNameClassReflectionExtensionTest extends \PHPStan\Testing\TestCase
+{
+
+	public function dataHasProperty(): array
+	{
+		return [
+			[
+				true,
+				\PhpParser\Node\Stmt\Class_::class,
+				'namespacedName',
+			],
+			[
+				true,
+				\PhpParser\Node\Stmt\Function_::class,
+				'namespacedName',
+			],
+			[
+				true,
+				\PhpParser\Node\FunctionLike::class,
+				'namespacedName',
+			],
+			[
+				false,
+				\PhpParser\Node\Expr\Closure::class,
+				'namespacedName',
+			],
+			[
+				false,
+				\PhpParser\Node\Stmt\Class_::class,
+				'foo',
+			],
+		];
+	}
+
+	/**
+	 * @dataProvider dataHasProperty
+	 * @param bool $expectedHas
+	 * @param string $className
+	 * @param string $propertyName
+	 */
+	public function testHasProperty(
+		bool $expectedHas,
+		string $className,
+		string $propertyName
+	)
+	{
+		$broker = $this->createBroker();
+		$classReflection = $broker->getClass($className);
+		$extension = new PhpParserNameClassReflectionExtension();
+		$this->assertSame($expectedHas, $extension->hasProperty($classReflection, $propertyName));
+	}
+
+}
diff --git a/tests/bootstrap.php b/tests/bootstrap.php
diff --git a/tests/phpunit.xml b/tests/phpunit.xml

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+includes:`
	`2`	`+ - vendor/phpstan/phpstan-phpunit/extension.neon`
	`3`	`+ - vendor/phpstan/phpstan-phpunit/rules.neon`