minor improvement on cognative load

phpsa · web-flow · commit 8952b45eb818 · 2020-09-25T13:43:49.000+12:00
diff --git a/src/Http/Resources/Contracts/AllowableFields.php b/src/Http/Resources/Contracts/AllowableFields.php
@@ -79,10 +79,8 @@ protected function mapFieldData($request, $fields)
         });
 
         foreach($missing as $field){
-            if(!array_key_exists(Helpers::snake($field), $data)){
-                if(method_exists($this->resource, 'get' . Helpers::camel($field) . 'Attribute')){
-                    $data[$field] = $this->resource->{'get' . Helpers::camel($field) . 'Attribute'}();
-                }
+            if(method_exists($this->resource, 'get' . Helpers::camel($field) . 'Attribute')){
+                $data[$field] = $this->resource->{ Helpers::camel($field)};
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -79,10 +79,8 @@ protected function mapFieldData($request, $fields)`
`79`	`79`	`});`
`80`	`80`
`81`	`81`	`foreach($missing as $field){`
`82`		`- if(!array_key_exists(Helpers::snake($field), $data)){`
`83`		`- if(method_exists($this->resource, 'get' . Helpers::camel($field) . 'Attribute')){`
`84`		`- $data[$field] = $this->resource->{'get' . Helpers::camel($field) . 'Attribute'}();`
`85`		`- }`
	`82`	`+ if(method_exists($this->resource, 'get' . Helpers::camel($field) . 'Attribute')){`
	`83`	`+ $data[$field] = $this->resource->{ Helpers::camel($field)};`
`86`	`84`	`}`
`87`	`85`	`}`
`88`	`86`