Skip to content

Commit dd06bb7

Browse files
MauricioFauthMauricioFauth
authored
Merge pull request #19682 from kamil-tekiela/Deprecated-Webauthn
Deprecated webauthn
2 parents a23e1bf + 0a5baf8 commit dd06bb7

File tree

4 files changed

+51
-180
lines changed

4 files changed

+51
-180
lines changed

‎composer.lock

+12-12
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎phpstan-baseline.neon

+14-125
Original file line numberDiff line numberDiff line change
@@ -16317,15 +16317,6 @@ parameters:
1631716317
count: 1
1631816318
path: src/WebAuthn/WebauthnLibServer.php
1631916319

16320-
-
16321-
message: '''
16322-
#^Call to deprecated method allowCredentials\(\) of class Webauthn\\PublicKeyCredentialRequestOptions\:
16323-
since 4\.7\.0\. No replacement\. Please use the property directly\.$#
16324-
'''
16325-
identifier: method.deprecated
16326-
count: 1
16327-
path: src/WebAuthn/WebauthnLibServer.php
16328-
1632916320
-
1633016321
message: '''
1633116322
#^Call to deprecated method createFromArray\(\) of class Webauthn\\AuthenticatorSelectionCriteria\:
@@ -16364,118 +16355,25 @@ parameters:
1636416355

1636516356
-
1636616357
message: '''
16367-
#^Call to deprecated method getId\(\) of class Webauthn\\PublicKeyCredentialRpEntity\:
16368-
since 4\.7\.0\. Please use the property directly\.$#
16369-
'''
16370-
identifier: method.deprecated
16371-
count: 1
16372-
path: src/WebAuthn/WebauthnLibServer.php
16373-
16374-
-
16375-
message: '''
16376-
#^Call to deprecated method getId\(\) of class Webauthn\\PublicKeyCredentialUserEntity\:
16377-
since 4\.7\.0\. Please use the property directly\.$#
16378-
'''
16379-
identifier: method.deprecated
16380-
count: 2
16381-
path: src/WebAuthn/WebauthnLibServer.php
16382-
16383-
-
16384-
message: '''
16385-
#^Call to deprecated method getPublicKeyCredentialId\(\) of class Webauthn\\PublicKeyCredentialSource\:
16386-
since 4\.7\.0\. Please use the property directly\.$#
16387-
'''
16388-
identifier: method.deprecated
16389-
count: 1
16390-
path: src/WebAuthn/WebauthnLibServer.php
16391-
16392-
-
16393-
message: '''
16394-
#^Call to deprecated method getRawId\(\) of class Webauthn\\PublicKeyCredential\:
16395-
since 4\.7\.0\. Please use the property directly\.$#
16396-
'''
16397-
identifier: method.deprecated
16398-
count: 1
16399-
path: src/WebAuthn/WebauthnLibServer.php
16400-
16401-
-
16402-
message: '''
16403-
#^Call to deprecated method getResponse\(\) of class Webauthn\\PublicKeyCredential\:
16404-
since 4\.7\.0\. Please use the property directly\.$#
16405-
'''
16406-
identifier: method.deprecated
16407-
count: 2
16408-
path: src/WebAuthn/WebauthnLibServer.php
16409-
16410-
-
16411-
message: '''
16412-
#^Call to deprecated method getUserHandle\(\) of class Webauthn\\PublicKeyCredentialSource\:
16413-
since 4\.7\.0\. Please use the property directly\.$#
16414-
'''
16415-
identifier: method.deprecated
16416-
count: 1
16417-
path: src/WebAuthn/WebauthnLibServer.php
16418-
16419-
-
16420-
message: '''
16421-
#^Call to deprecated method setAttestation\(\) of class Webauthn\\PublicKeyCredentialCreationOptions\:
16422-
since 4\.7\.0\. Please use the \{self\:\:create\} instead\.$#
16423-
'''
16424-
identifier: method.deprecated
16425-
count: 1
16426-
path: src/WebAuthn/WebauthnLibServer.php
16427-
16428-
-
16429-
message: '''
16430-
#^Call to deprecated method setAuthenticatorSelection\(\) of class Webauthn\\PublicKeyCredentialCreationOptions\:
16431-
since 4\.7\.0\. Please use the \{self\:\:create\} instead\.$#
16432-
'''
16433-
identifier: method.deprecated
16434-
count: 1
16435-
path: src/WebAuthn/WebauthnLibServer.php
16436-
16437-
-
16438-
message: '''
16439-
#^Call to deprecated method setExtensions\(\) of class Webauthn\\PublicKeyCredentialOptions\:
16440-
since 4\.7\.0\. Please use the \{self\:\:create\} instead\.$#
16441-
'''
16442-
identifier: method.deprecated
16443-
count: 2
16444-
path: src/WebAuthn/WebauthnLibServer.php
16445-
16446-
-
16447-
message: '''
16448-
#^Call to deprecated method setRpId\(\) of class Webauthn\\PublicKeyCredentialRequestOptions\:
16449-
since 4\.7\.0\. Please use the property directly\.$#
16450-
'''
16451-
identifier: method.deprecated
16452-
count: 1
16453-
path: src/WebAuthn/WebauthnLibServer.php
16454-
16455-
-
16456-
message: '''
16457-
#^Call to deprecated method setTimeout\(\) of class Webauthn\\PublicKeyCredentialOptions\:
16458-
since 4\.7\.0\. Please use the \{self\:\:create\} instead\.$#
16358+
#^Call to method create\(\) of deprecated class Webauthn\\PublicKeyCredentialLoader\:
16359+
since 4\.8\.0 and will be removed in 5\.0\.0\. Please use the Symfony serializer instead$#
1645916360
'''
16460-
identifier: method.deprecated
16361+
identifier: staticMethod.deprecatedClass
1646116362
count: 2
1646216363
path: src/WebAuthn/WebauthnLibServer.php
1646316364

1646416365
-
16465-
message: '''
16466-
#^Call to deprecated method setUserVerification\(\) of class Webauthn\\PublicKeyCredentialRequestOptions\:
16467-
since 4\.7\.0\. Please use the property directly\.$#
16468-
'''
16469-
identifier: method.deprecated
16366+
message: '#^Call to method findAllForUserEntity\(\) of deprecated interface Webauthn\\PublicKeyCredentialSourceRepository\.$#'
16367+
identifier: method.deprecatedInterface
1647016368
count: 1
1647116369
path: src/WebAuthn/WebauthnLibServer.php
1647216370

1647316371
-
1647416372
message: '''
16475-
#^Call to method create\(\) of deprecated class Webauthn\\PublicKeyCredentialLoader\:
16373+
#^Call to method load\(\) of deprecated class Webauthn\\PublicKeyCredentialLoader\:
1647616374
since 4\.8\.0 and will be removed in 5\.0\.0\. Please use the Symfony serializer instead$#
1647716375
'''
16478-
identifier: staticMethod.deprecatedClass
16376+
identifier: method.deprecatedClass
1647916377
count: 2
1648016378
path: src/WebAuthn/WebauthnLibServer.php
1648116379

@@ -16509,21 +16407,12 @@ parameters:
1650916407
count: 6
1651016408
path: src/WebAuthn/WebauthnLibServer.php
1651116409

16512-
-
16513-
message: '''
16514-
#^Instantiation of deprecated class Webauthn\\AuthenticationExtensions\\AuthenticationExtensionsClientInputs\:
16515-
since 4\.8\.0\. Use \{Webauthn\\AuthenticationExtensions\\AuthenticationExtensions\} instead\.$#
16516-
'''
16517-
identifier: new.deprecated
16518-
count: 2
16519-
path: src/WebAuthn/WebauthnLibServer.php
16520-
1652116410
-
1652216411
message: '''
1652316412
#^Instantiation of deprecated class Webauthn\\TokenBinding\\IgnoreTokenBindingHandler\:
1652416413
Since 4\.3\.0 and will be removed in 5\.0\.0$#
1652516414
'''
16526-
identifier: new.deprecated
16415+
identifier: new.deprecatedClass
1652716416
count: 2
1652816417
path: src/WebAuthn/WebauthnLibServer.php
1652916418

@@ -18792,12 +18681,6 @@ parameters:
1879218681
count: 7
1879318682
path: tests/unit/GitTest.php
1879418683

18795-
-
18796-
message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertNotNull\(\) with array\{hash\: string, branch\: string\|false, message\: string, author\: array\{name\: string, email\: string, date\: string\}, committer\: array\{name\: string, email\: string, date\: string\}, is_remote_commit\: bool, is_remote_branch\: bool\} will always evaluate to true\.$#'
18797-
identifier: staticMethod.alreadyNarrowedType
18798-
count: 1
18799-
path: tests/unit/GitTest.php
18800-
1880118684
-
1880218685
message: '#^Cannot unset offset ''git_location'' on array\<mixed, mixed\>\.$#'
1880318686
identifier: unset.offset
@@ -19518,6 +19401,12 @@ parameters:
1951819401
count: 2
1951919402
path: tests/unit/Plugins/Export/ExportSqlTest.php
1952019403

19404+
-
19405+
message: '#^Parameter \#2 \$haystack of static method PHPUnit\\Framework\\Assert\:\:assertStringContainsString\(\) expects string, string\|null given\.$#'
19406+
identifier: argument.type
19407+
count: 3
19408+
path: tests/unit/Plugins/Export/ExportSqlTest.php
19409+
1952119410
-
1952219411
message: '#^Property PhpMyAdmin\\Config\:\:\$selectedServer \(array\{host\: string, port\: string, socket\: string, ssl\: bool, ssl_key\: string\|null, ssl_cert\: string\|null, ssl_ca\: string\|null, ssl_ca_path\: string\|null, \.\.\.\}\) does not accept array\{host\: string, port\: 80, socket\: string, ssl\: bool, ssl_key\: string\|null, ssl_cert\: string\|null, ssl_ca\: string\|null, ssl_ca_path\: string\|null, \.\.\.\}\.$#'
1952319412
identifier: assign.propertyType

‎psalm-baseline.xml

-19
Original file line numberDiff line numberDiff line change
@@ -9574,8 +9574,6 @@
95749574
<code><![CDATA[PublicKeyCredentialLoader::create($attestationObjectLoader)]]></code>
95759575
<code><![CDATA[PublicKeyCredentialLoader::create($attestationObjectLoader)]]></code>
95769576
<code><![CDATA[PublicKeyCredentialLoader::create($attestationObjectLoader)]]></code>
9577-
<code><![CDATA[new AuthenticationExtensionsClientInputs()]]></code>
9578-
<code><![CDATA[new AuthenticationExtensionsClientInputs()]]></code>
95799577
<code><![CDATA[new IgnoreTokenBindingHandler()]]></code>
95809578
<code><![CDATA[new IgnoreTokenBindingHandler()]]></code>
95819579
</DeprecatedClass>
@@ -9597,23 +9595,6 @@
95979595
])]]></code>
95989596
<code><![CDATA[PublicKeyCredentialSource::createFromArray($data)]]></code>
95999597
<code><![CDATA[PublicKeyCredentialSource::createFromArray($data[base64_encode($publicKeyCredentialId)])]]></code>
9600-
<code><![CDATA[allowCredentials]]></code>
9601-
<code><![CDATA[getId]]></code>
9602-
<code><![CDATA[getId]]></code>
9603-
<code><![CDATA[getId]]></code>
9604-
<code><![CDATA[getPublicKeyCredentialId]]></code>
9605-
<code><![CDATA[getRawId]]></code>
9606-
<code><![CDATA[getResponse]]></code>
9607-
<code><![CDATA[getResponse]]></code>
9608-
<code><![CDATA[getUserHandle]]></code>
9609-
<code><![CDATA[setAttestation]]></code>
9610-
<code><![CDATA[setAuthenticatorSelection]]></code>
9611-
<code><![CDATA[setExtensions]]></code>
9612-
<code><![CDATA[setExtensions]]></code>
9613-
<code><![CDATA[setRpId]]></code>
9614-
<code><![CDATA[setTimeout]]></code>
9615-
<code><![CDATA[setTimeout]]></code>
9616-
<code><![CDATA[setUserVerification]]></code>
96179598
</DeprecatedMethod>
96189599
<MixedArgument>
96199600
<code><![CDATA[$assertionResponseDecoded['response']['authenticatorData']]]></code>

0 commit comments

Comments
 (0)