Lowercase refs in pecl artifacts

Author: shivammathur

.github/workflows/pecl.yml

@@ -101,15 +101,19 @@ jobs:
       - name: Release
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          REF: ${{ inputs.extension-ref }}
+          URL: ${{ inputs.extension-url }}
+          REPO: ${{ github.repository }}
         run: |
           ls -l artifacts
-          extension=$(basename "${{ inputs.extension-url }}")
-          mkdir -p /tmp/$extension/${{ inputs.extension-ref }}/
-          cp -a artifacts/* /tmp/$extension/${{ inputs.extension-ref }}/
+          ref=$(echo "$REF" | tr "[:upper:]" "[:lower:]")
+          extension=$(basename "$URL")
+          mkdir -p /tmp/$extension/$ref/
+          cp -a artifacts/* /tmp/$extension/$ref/
           cd /tmp || exit 1
-          zip -r $extension-${{ inputs.extension-ref }}.zip $extension
-          if ! gh release view pecl -R ${{ github.repository }}; then
-            gh release create pecl $extension-${{ inputs.extension-ref }}.zip -t pecl -n pecl -R ${{ github.repository }}
+          zip -r $extension-$ref.zip $extension
+          if ! gh release view pecl -R $REPO; then
+            gh release create pecl $extension-$ref.zip -t pecl -n pecl -R $REPO
           else
-            gh release upload pecl $extension-${{ inputs.extension-ref }}.zip -R ${{ github.repository }} --clobber
+            gh release upload pecl $extension-$ref.zip -R $REPO --clobber
           fi

extension/BuildPhpExtension/private/Add-Package.ps1

@@ -48,15 +48,21 @@ function Add-Package {
                     Copy-Item -Path $pdbFilePath -Destination artifacts -Force
                 }
             }
-            # TODO: Filter these using deplister
+
             if(Test-Path ..\deps\bin) {
-                Get-ChildItem -Path ..\deps\bin -Recurse -Include "*.dll", "*.pdb" | ForEach-Object {
-                    if(-not(Test-Path "php-bin\$($_.Name.Split('.')[0]).dll")) {
-                        if($_.Extension -eq ".dll" -or (Test-Path ([IO.Path]::ChangeExtension($_.FullName, "dll")))) {
+                $dllMap = Invoke-WebRequest -Uri "https://downloads.php.net/~windows/pecl/deps/dllmapping.json"
+                Get-ChildItem -Path ..\deps\bin -Recurse -Include "*.dll" | ForEach-Object {
+                    if($dllMap.content.Contains($_.Name)) {
+                        if(-not(Test-Path "php-bin\$($_.Name)")) {
                             Copy-Item -Path $_.FullName -Destination artifacts -Force
                         }
                     }
                 }
+                Get-ChildItem -Path ..\deps\bin -Recurse -Include "*.pdb" | ForEach-Object {
+                    if(Test-Path "artifacts\$($_.Name.Split('.')[0]).dll") {
+                        Copy-Item -Path $_.FullName -Destination artifacts -Force
+                    }
+                }
                 if(Test-Path (Join-Path -Path ..\deps\bin -ChildPath "*.xml")) {
                     New-Item -ItemType Directory -Path artifacts\config -Force | Out-Null
                     Get-ChildItem -Path ..\deps\bin -Recurse -Filter "*.xml" | ForEach-Object {
@@ -87,7 +93,7 @@ function Add-Package {
                     }
                 }
             } else {
-                $artifact = "php_$($Config.package_name)-$($Config.ref)-$($Config.php_version)-$($Config.ts)-$($Config.vs_version)-$arch"
+                $artifact = "php_$($Config.package_name)-$($Config.ref.ToLower())-$($Config.php_version)-$($Config.ts)-$($Config.vs_version)-$arch"
             }
 
             7z a -sdel "$artifact.zip" *

extension/BuildPhpExtension/private/Invoke-Build.ps1

@@ -26,9 +26,13 @@ Function Invoke-Build {
 
             $builder = "php-sdk\phpsdk-$($Config.vs_version)-$($Config.Arch).bat"
             $task = (Get-Item -Path "." -Verbose).FullName + '\task.bat'
+            $ref = $Config.ref
+            if($env:ARTIFACT_NAMING_SCHEME -ne 'pie') {
+                $ref = $Config.ref.ToLower()
+            }
             $suffix = "php_" + (@(
                 $Config.name,
-                $Config.ref,
+                $ref,
                 $Config.php_version,
                 $Config.ts,
                 $Config.vs_version,