Skip to content

Fixed GH-18266: round() - Added edge case generation logic #18936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
Open

Fixed GH-18266: round() - Added edge case generation logic #18936

wants to merge 1 commit into from

Conversation

SakiTakamachi
Copy link
Member

Added edge case generation logic for cases where the precision is so fine that adding 0.5 does not change the value.

@SakiTakamachi SakiTakamachi mentioned this pull request Jun 25, 2025
Open
@SakiTakamachi SakiTakamachi marked this pull request as ready for review June 25, 2025 11:29
@SakiTakamachi SakiTakamachi requested a review from bukka as a code owner June 25, 2025 11:29
@SakiTakamachi
Added edge case generation logic for cases where the precision is so …
bf97589 
…fine that adding `0.5` does not change the value.
@SakiTakamachi SakiTakamachi marked this pull request as draft June 27, 2025 04:55
@SakiTakamachi SakiTakamachi changed the base branch from master to PHP-8.4 June 27, 2025 04:55
@SakiTakamachi SakiTakamachi marked this pull request as ready for review June 27, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SakiTakamachi