Skip to content

Commit 8db89af

Browse files
authored
ext/intl: Remove redundant SKIPIF checks from intl tests (#24416)
These SKIPIFs are hidding issues. If they are not then we are in trouble and the tests should reflect that.
1 parent 3d84b8f commit 8db89af

15 files changed

Lines changed: 0 additions & 43 deletions

‎ext/intl/tests/bug62915-2.phpt‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@
22
Bug #62915: cloning of several classes is defective
33
--EXTENSIONS--
44
intl
5-
--SKIPIF--
6-
<?php
7-
if (!class_exists('Spoofchecker'))
8-
die('skip intl extension does not have spoof checker');
9-
?>
105
--FILE--
116
<?php
127
class A extends IntlDateFormatter {

‎ext/intl/tests/bug72506.phpt‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ Actually, the $info array should be populated for these cases, but at least it's
55
not clear yet with which values exactly.
66
--EXTENSIONS--
77
intl
8-
--SKIPIF--
9-
<?php
10-
if (!defined('INTL_IDNA_VARIANT_UTS46')) die('skip no UTS #46 API');
11-
?>
128
--FILE--
139
<?php
1410
// ASCII domain name with 255 characters

‎ext/intl/tests/idn_uts46_basic.phpt‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@
22
IDN UTS #46 API basic tests
33
--EXTENSIONS--
44
intl
5-
--SKIPIF--
6-
<?php
7-
if (!defined('INTL_IDNA_VARIANT_UTS46'))
8-
die('skip no UTS #46 API');
9-
?>
105
--FILE--
116
<?php
127
$utf8dn = "www.fußball.com";

‎ext/intl/tests/idn_uts46_errors.phpt‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@
22
IDN UTS #46 API error tests
33
--EXTENSIONS--
44
intl
5-
--SKIPIF--
6-
<?php
7-
if (!defined('INTL_IDNA_VARIANT_UTS46'))
8-
die('skip no UTS #46 API');
9-
?>
105
--FILE--
116
<?php
127
echo "=> PHP level errors", "\n";

‎ext/intl/tests/normalizer_normalize_kc_cf.phpt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
normalize() NFKC_Casefold
33
--EXTENSIONS--
44
intl
5-
--SKIPIF--
6-
<?php if (!defined('Normalizer::FORM_KC_CF')) print 'skip Normalizer::FORM_KC_CF constant not defined'; ?>
75
--FILE--
86
<?php
97

‎ext/intl/tests/spoofchecker_002.phpt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
spoofchecker confusable tests
33
--EXTENSIONS--
44
intl
5-
--SKIPIF--
6-
<?php if(!class_exists("Spoofchecker")) print 'skip'; ?>
75
--FILE--
86
<?php
97

‎ext/intl/tests/spoofchecker_003.phpt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
spoofchecker with locale settings
33
--EXTENSIONS--
44
intl
5-
--SKIPIF--
6-
<?php if(!class_exists("Spoofchecker")) print 'skip'; ?>
75
--FILE--
86
<?php
97

‎ext/intl/tests/spoofchecker_005.phpt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
spoofchecker with settings changed
33
--EXTENSIONS--
44
intl
5-
--SKIPIF--
6-
<?php if(!class_exists("Spoofchecker")) print 'skip'; ?>
75
--FILE--
86
<?php
97

‎ext/intl/tests/spoofchecker_006.phpt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
spoofchecker suspicious character checker
33
--EXTENSIONS--
44
intl
5-
--SKIPIF--
6-
<?php if(!class_exists("Spoofchecker")) print 'skip'; ?>
75
--FILE--
86
<?php
97

‎ext/intl/tests/spoofchecker_007.phpt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
spoofchecker with restriction level
33
--EXTENSIONS--
44
intl
5-
--SKIPIF--
6-
<?php if(!class_exists("Spoofchecker")) print 'skip'; ?>
75
--FILE--
86
<?php
97

0 commit comments

Comments
 (0)