array_unshift: Use specialised iteration macro (#20410)

ndossche · web-flow · commit 877e758a3b5b · 2025-11-06T23:36:43.000+01:00
Forgot this while working on GH-20353, but this could avoid some checks depending on the compiler optimizations.
diff --git a/ext/standard/array.c b/ext/standard/array.c
@@ -3763,7 +3763,7 @@ PHP_FUNCTION(array_unshift)
 			zend_hash_next_index_insert_new(&new_hash, &args[i]);
 		}
 
-		ZEND_HASH_FOREACH_STR_KEY_VAL(Z_ARRVAL_P(stack), key, value) {
+		ZEND_HASH_MAP_FOREACH_STR_KEY_VAL(Z_ARRVAL_P(stack), key, value) {
 			if (key) {
 				zend_hash_add_new(&new_hash, key, value);
 			} else {

Original file line number	Diff line number	Diff line change
`@@ -3763,7 +3763,7 @@ PHP_FUNCTION(array_unshift)`
`3763`	`3763`	`zend_hash_next_index_insert_new(&new_hash, &args[i]);`
`3764`	`3764`	`}`
`3765`	`3765`
`3766`		`- ZEND_HASH_FOREACH_STR_KEY_VAL(Z_ARRVAL_P(stack), key, value) {`
	`3766`	`+ ZEND_HASH_MAP_FOREACH_STR_KEY_VAL(Z_ARRVAL_P(stack), key, value) {`
`3767`	`3767`	`if (key) {`
`3768`	`3768`	`zend_hash_add_new(&new_hash, key, value);`
`3769`	`3769`	`} else {`