Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 829187c

Browse files
committedSep 13, 2024··
Fix CS in readline tests: added missing reasons, removed redundant skip conditions...
1 parent 2346e5c commit 829187c

7 files changed

+3
-13
lines changed
 

‎ext/readline/tests/bug69054.phpt

-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
Bug #69054 (Null dereference in readline_(read|write)_history() without parameters)
33
--EXTENSIONS--
44
readline
5-
--SKIPIF--
6-
<?php if (!function_exists('readline_add_history')) die("skip"); ?>
75
--INI--
86
open_basedir="{TMP}"
97
--FILE--

‎ext/readline/tests/readline_add_history_001.phpt

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ readline_add_history(): Basic test
33
--EXTENSIONS--
44
readline
55
--SKIPIF--
6-
<?php if (!function_exists('readline_list_history')) die("skip"); ?>
6+
<?php if (!function_exists('readline_list_history')) die("skip readline_list_history not available"); ?>
77
--FILE--
88
<?php
99

‎ext/readline/tests/readline_list_history_001.phpt

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ readline_list_history(): Basic test
33
--EXTENSIONS--
44
readline
55
--SKIPIF--
6-
<?php if (!function_exists('readline_list_history')) die("skip"); ?>
6+
<?php if (!function_exists('readline_list_history')) die("skip readline_list_history not available"); ?>
77
--FILE--
88
<?php
99

‎ext/readline/tests/readline_read_history_001.phpt

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ readline_read_history(): Basic test
44
readline
55
--SKIPIF--
66
<?php
7-
if (!function_exists('readline_list_history')) die("skip");
7+
if (!function_exists('readline_list_history')) die("skip readline_list_history not available");
88
if (getenv('SKIP_REPEAT')) die("skip readline has global state");
99
?>
1010
--FILE--

‎ext/readline/tests/readline_read_history_open_basedir_001.phpt

-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
readline_read_history(): Test that open_basedir is respected
33
--EXTENSIONS--
44
readline
5-
--SKIPIF--
6-
<?php if (!function_exists('readline_read_history')) die("skip"); ?>
75
--INI--
86
open_basedir=/tmp/some-sandbox
97
--FILE--

‎ext/readline/tests/readline_without_input.phpt

-4
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ Jonathan Stevens <info at jonathanstevens dot be>
55
User Group: PHP-WVL & PHPGent #PHPTestFest
66
--EXTENSIONS--
77
readline
8-
--SKIPIF--
9-
<?php
10-
if (!function_exists('readline')) die("skip readline() not available");
11-
?>
128
--FILE--
139
<?php
1410
var_dump(readline());

‎ext/readline/tests/readline_write_history_open_basedir_001.phpt

-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
readline_write_history(): Test that open_basedir is respected
33
--EXTENSIONS--
44
readline
5-
--SKIPIF--
6-
<?php if (!function_exists('readline_write_history')) die("skip"); ?>
75
--INI--
86
open_basedir=/tmp/some-sandbox
97
--FILE--

0 commit comments

Comments
 (0)
Please sign in to comment.