Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting dbType to enum is not totally correct #45

Closed
SOHELAHMED7 opened this issue Sep 6, 2024 · 0 comments · Fixed by #46
Closed

Setting dbType to enum is not totally correct #45

SOHELAHMED7 opened this issue Sep 6, 2024 · 0 comments · Fixed by #46
Assignees

Comments

@SOHELAHMED7
Copy link
Member

Resolve below TODO:

File: src/lib/migrations/MysqlMigrationBuilder.php

L33

protected function buildColumnChanges(ColumnSchema $current, ColumnSchema $desired, array $changed):void
    {
        $newColumn = clone $current;
        foreach ($changed as $attr) {
            $newColumn->$attr = $desired->$attr;
        }
        if (static::isEnum($newColumn)) {
            $newColumn->dbType = 'enum'; // TODO this is concretely not correct
        }

Part of #10

and

Part of cebe#180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant