Skip to content

Commit e571d2c

Browse files
committed
Refactor + fix failing test
1 parent d0f86ce commit e571d2c

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

Diff for: TODO.taskpaper

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
TODO.taskpaper
22

33
✔ fix failing tests @done (25-03-21 16:20)
4-
☐ resolve all TODOs
4+
✔ Implement code generation for nested module in `x-route` and other pertinent place @done (25-03-26 11:38)
55
☐ resolve all sub tasks of issue - Support for Yii Modules in x-route and pertinent places #14
6-
Implement code generation for nested module in `x-route` and other pertinent place
6+
resolve all TODOs
77
☐ delete this file

Diff for: src/lib/items/OptionsRoutesTrait.php renamed to src/lib/items/ActionHelperTrait.php

+11-1
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,18 @@
77

88
namespace cebe\yii2openapi\lib\items;
99

10-
trait OptionsRoutesTrait
10+
trait ActionHelperTrait
1111
{
12+
/**
13+
* @var ?string
14+
*/
15+
public $xRoute;
16+
17+
/**
18+
* @var array list of module this action is part of. 'key' is module ID and 'value' is path where Module.php file must be generated
19+
*/
20+
public $modulesList = [];
21+
1222
public function getOptionsRoute():string
1323
{
1424
if (!empty($this->prefixSettings)) {

Diff for: src/lib/items/FractalAction.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
*/
3333
final class FractalAction extends BaseObject
3434
{
35-
use OptionsRoutesTrait;
35+
use ActionHelperTrait;
3636

3737
/**@var string* */
3838
public $id;

Diff for: src/lib/items/RestAction.php

+1-11
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
*/
3232
final class RestAction extends BaseObject
3333
{
34-
use OptionsRoutesTrait;
34+
use ActionHelperTrait;
3535

3636
/**@var string* */
3737
public $id;
@@ -70,16 +70,6 @@ final class RestAction extends BaseObject
7070
*/
7171
public $responseWrapper;
7272

73-
/**
74-
* @var ?string
75-
*/
76-
public $xRoute;
77-
78-
/**
79-
* @var array list of module this action is part of. 'key' is module ID and 'value' is path where Module.php file must be generated
80-
*/
81-
public $modulesList = [];
82-
8373
/**
8474
* @var bool
8575
* @see $isDuplicate

0 commit comments

Comments
 (0)