Skip to content

Commit e0e46c2

Browse files
authoredNov 29, 2024··
Merge pull request #18 from doyouhaobaby/master
update for php8.4
2 parents 97e223d + 0896392 commit e0e46c2

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed
 

‎.github/workflows/test.yml

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
- 8.1
2020
- 8.2
2121
- 8.3
22+
- 8.4
2223
fail-fast: false
2324

2425
steps:

‎src/PhpFunctionsScanner.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class PhpFunctionsScanner implements FunctionsScannerInterface
1212
protected Parser $parser;
1313
protected ?array $validFunctions;
1414

15-
public function __construct(array $validFunctions = null, Parser $parser = null)
15+
public function __construct(?array $validFunctions = null, ?Parser $parser = null)
1616
{
1717
$this->validFunctions = $validFunctions;
1818
$this->parser = $parser ?: (new ParserFactory())->createForNewestSupportedVersion();

‎src/PhpNodeVisitor.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class PhpNodeVisitor implements NodeVisitor
2121
/** @var Comment[] */
2222
protected array $bufferComments = [];
2323

24-
public function __construct(string $filename, array $validFunctions = null)
24+
public function __construct(string $filename, ?array $validFunctions = null)
2525
{
2626
$this->filename = $filename;
2727
$this->validFunctions = $validFunctions;

‎src/PhpScanner.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ protected function saveTranslation(
4343
?string $domain,
4444
?string $context,
4545
string $original,
46-
string $plural = null
46+
?string $plural = null
4747
): ?Translation {
4848
$translation = parent::saveTranslation($domain, $context, $original, $plural);
4949

0 commit comments

Comments
 (0)
Please sign in to comment.