avoid case where we build "is_null(null)"

Author: clemzarch

src/Builder/Capacity/Lookup/All.php

@@ -57,17 +57,15 @@ public function getNode(): Node
         return (new IsolatedValueAppendingBuilder(
             new Node\Expr\Variable('input'),
             new Node\Expr\Variable('lookup'),
-            [
-                new Node\Stmt\If_(
+            array_filter([
+                $this->code ? new Node\Stmt\If_(
                     cond: new Node\Expr\FuncCall(
                         name: new Node\Name('is_null'),
-                        args: array_filter(
-                            [
-                                null !== $this->code ? new Node\Arg(
-                                    value: $this->code,
-                                ) : null,
-                            ],
-                        ),
+                        args: [
+                            new Node\Arg(
+                                value: $this->code,
+                            )
+                        ],
                     ),
                     subNodes: [
                         'stmts' => [
@@ -78,7 +76,7 @@ public function getNode(): Node
                             ),
                         ],
                     ],
-                ),
+                ) : null,
                 new Node\Stmt\TryCatch(
                     stmts: [
                         new Node\Stmt\Expression(
@@ -169,7 +167,7 @@ public function getNode(): Node
                 new Node\Stmt\Return_(
                     expr: new Node\Expr\Variable('items'),
                 ),
-            ],
+            ]),
             new Node\Expr\Variable('bucket')
         ))->getNode();
     }

src/Builder/Capacity/Lookup/ListPerPage.php

@@ -57,17 +57,15 @@ public function getNode(): Node
         return (new IsolatedValueAppendingBuilder(
             new Node\Expr\Variable('input'),
             new Node\Expr\Variable('lookup'),
-            [
-                new Node\Stmt\If_(
+            array_filter([
+                $this->code ? new Node\Stmt\If_(
                     cond: new Node\Expr\FuncCall(
                         name: new Node\Name('is_null'),
-                        args: array_filter(
-                            [
-                                null !== $this->code ? new Node\Arg(
-                                    value: $this->code,
-                                ) : null,
-                            ],
-                        ),
+                        args: [
+                            new Node\Arg(
+                                value: $this->code,
+                            ),
+                        ],
                     ),
                     subNodes: [
                         'stmts' => [
@@ -78,7 +76,7 @@ public function getNode(): Node
                             ),
                         ],
                     ],
-                ),
+                ) : null,
                 new Node\Stmt\TryCatch(
                     stmts: [
                         new Node\Stmt\Expression(
@@ -169,7 +167,7 @@ public function getNode(): Node
                 new Node\Stmt\Return_(
                     expr: new Node\Expr\Variable('items'),
                 ),
-            ],
+            ]),
             new Node\Expr\Variable('bucket')
         ))->getNode();
     }

src/Capacity/Lookup/All.php

@@ -93,8 +93,8 @@ private function compileFilters(array ...$filters): Node\Expr
     public function getBuilder(array $config): Builder
     {
         $builder = (new Akeneo\Builder\Capacity\Lookup\All())
-            ->withType((string) $config['type'])
             ->withEndpoint(new Node\Identifier(sprintf('get%sApi', ucfirst((string) $config['type']))))
+            ->withType($config['type'])
         ;
 
         if (isset($config['search']) && \is_array($config['search'])) {