Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export PhosphorIcon type #29

Open
IanWitham opened this issue Aug 20, 2022 · 4 comments
Open

Export PhosphorIcon type #29

IanWitham opened this issue Aug 20, 2022 · 4 comments
Labels
next Issue will be solved by the next major release of the library

Comments

@IanWitham
Copy link

Hi, I'd like to ensure a PhosphorIcon is being passed as a prop, but unfortunately this type isn't exported by phosphor-vue.

What I'd like to do is this:

const props = defineProps<{
  label: string;
  icon: PhosphorIcon;
}>();

And then render with something like this:

    <component
      :is="icon"
      :size="20"
      :width="20"
      :weight="isActive ? 'fill' : 'regular'"
    />

Would exporting the PhosphorIcon type make sense?

@dnlsndr dnlsndr added the next Issue will be solved by the next major release of the library label Jan 28, 2023
@dnlsndr
Copy link
Collaborator

dnlsndr commented Jan 28, 2023

I'll have a look if we can implement something like that.

@dubem-design
Copy link

Would love this too

@DerDeathraven
Copy link

just ran into this issue... would be awesome

@Alxilin
Copy link

Alxilin commented Nov 6, 2023

Hi guys, when are you planning to make a next major release to fix this issue? Just asking to understand if we need to fork the repo or to wait... Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next Issue will be solved by the next major release of the library
Projects
None yet
Development

No branches or pull requests

5 participants