Layout conflict check

[shogochiai]

What is preventing you to have storage layout conflict checker with this nice scripts?

[phenix3443]

Didn't get your point, can you elaborate?

[shogochiai]

Thanks for quick resp.

For example, you can take the version N and version N+1 in the script, and can use cheatcodes' ffi function to take target files as text. But such text analysis and comparison process is inefficient for Solidity code, so that you can bypass such logic to OpenZeppelin's storage layout checker.

Other workaround is taking two filenames as argument of the upgrade command, and see&compare those files before you run the upgrade script, then passing the check, run upgrade script with those target names.

[phenix3443]

I just started using solidity, openzepplin, so I don't really understand what you mean, can you illustrate this with a PR? Thank you very much.

Thanks for quick resp.

For example, you can take the version N and version N+1 in the script, and can use cheatcodes' ffi function to take target files as text. But such text analysis and comparison process is inefficient for Solidity code, so that you can bypass such logic to OpenZeppelin's storage layout checker.

Other workaround is taking two filenames as argument of the upgrade command, and see&compare those files before you run the upgrade script, then passing the check, run upgrade script with those target names.