Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSortable is not used #16357

Open
guillep opened this issue Mar 28, 2024 · 1 comment · May be fixed by #17980
Open

TSortable is not used #16357

guillep opened this issue Mar 28, 2024 · 1 comment · May be fixed by #17980
Labels
Type: Cleanup

Comments

@guillep
Copy link
Member

guillep commented Mar 28, 2024

Collection and Heap duplicate the implementation of TSortable.
TSortable has no users.

Are we thinking about external libraries implementing this trait?
@Ducasse
Copy link
Member

Ducasse commented Mar 29, 2024

No idea and probably we should remove it.

@pavel-krivanek pavel-krivanek mentioned this issue Apr 27, 2024
Closed
jecisc added a commit to jecisc/pharo that referenced this issue Mar 11, 2025
@jecisc
Deprecate TSortable
b8f42d7 
Multiple people already agreed to remove the trait with no user in Pharo issues. Pavel did a first PR that has failures.
In this change I am updating the tests using this trait, I deprecate it and I remove the package that contained it before.

Fixes pharo-project#16357
jecisc added a commit to jecisc/pharo that referenced this issue Mar 11, 2025
@jecisc
Deprecate TSortable
94d4904 
Multiple people already agreed to remove the trait with no user in Pharo issues. Pavel did a first PR that has failures.
In this change I am updating the tests using this trait, I deprecate it and I remove the package that contained it before.

Fixes pharo-project#16357
@jecisc jecisc linked a pull request Mar 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Cleanup
Projects
None yet
Milestone
No milestone
2 participants
@Ducasse @guillep