Fixed issue with unused code; Corrected logic for unknown include

Author: niden

api/controllers/BaseController.php

@@ -52,15 +52,13 @@ class BaseController extends Controller
      * Get the company/companies
      *
      * @param int    $id
-     * @param string $relationships
      *
      * @return array
      */
-    public function callAction($id = 0, $relationships = '')
+    public function callAction($id = 0)
     {
         $includes   = $this->request->getQuery('includes', [Filter::FILTER_STRING, Filter::FILTER_TRIM], '');
         $parameters = $this->checkIdParameter($id);
-        $parameter  = $this->filter->sanitize($relationships, [Filter::FILTER_STRING, Filter::FILTER_TRIM]);
         $results    = $this->getRecords($this->config, $this->cache, $this->model, $parameters, $this->orderBy);
         $related    = [];
 
@@ -70,11 +68,9 @@ public function callAction($id = 0, $relationships = '')
             if (true !== empty($includes)) {
                 $requestedIncludes = explode(',', $includes);
                 foreach ($requestedIncludes as $include) {
-                    if (true !== in_array($include, $this->includes)) {
-                        return $this->send404();
+                    if (true === in_array($include, $this->includes)) {
+                        $related[] = strtolower($include);
                     }
-
-                    $related[] = strtolower($include);
                 }
             }
         }

tests/api/Companies/GetCest.php

@@ -36,7 +36,7 @@ public function getCompany(ApiTester $I)
     /**
      * @param ApiTester $I
      */
-    public function getCompanyUnknownRelationship(ApiTester $I)
+    public function getCompanyUnknownInclude(ApiTester $I)
     {
         $I->addApiUserRecord();
         $token = $I->apiLogin();
@@ -45,7 +45,13 @@ public function getCompanyUnknownRelationship(ApiTester $I)
         $I->haveHttpHeader('Authorization', 'Bearer ' . $token);
         $I->sendGET(sprintf(Data::$companiesRecordRelationshipUrl, $company->get('id'), 'unknown'));
         $I->deleteHeader('Authorization');
-        $I->seeResponseIs404();
+        $I->seeResponseIsSuccessful();
+        $I->seeSuccessJsonResponse(
+            'data',
+            [
+                Data::companyResponse($company),
+            ]
+        );
     }
 
     /**