Fix plot torsional and axial modes #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
- Coverage 84.52% 83.53% -0.99%
==========================================
Files 35 37 +2
Lines 7966 8090 +124
==========================================
+ Hits 6733 6758 +25
- Misses 1233 1332 +99
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
raphaeltimbo
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1096
This PR introduces corrections related to the plotting of mode shapes and includes new methods to handle the plotting of torsional and axial modes in the 6-DoF model.
The
plot_with_mode_shapemethod was not functioning due to changes in thefrequency_unitsparameter in theModalResultsclass from previous PRs. To resolve this, corrections were made to managespeed_unitsseparately fromfrequency_units.Additionally, new methods were added to the Shape class, including
_plot_torsionaland_plot_axial, which are now integrated into theplot_mode_2dandplot_mode_3dmethods ofModalResults. For 3D plots, an optional animation feature was added, which can be activated by passinganimation=Trueas an argument.