chore: improve decoder test

petrknap · petrknap · commit 8d4f1d456fd1 · 2024-03-31T14:30:26.000+02:00
diff --git a/tests/DecoderTest.php b/tests/DecoderTest.php
@@ -49,9 +49,12 @@ public function testChecksumThrows(string $data, string $algorithm): void
 
     public static function dataChecksumThrows(): array
     {
+        $dataSet = self::dataChecksum()[CoderInterface::CHECKSUM_ALGORITHM];
         return [
-            'wrong algorithm' => ['', '?'],
-            'wrong checksum' => ['?', CoderInterface::CHECKSUM_ALGORITHM],
+            'wrong algorithm' => [$dataSet[1], '?'],
+            'short data' => ['?', CoderInterface::CHECKSUM_ALGORITHM],
+            'wrong data' => [$dataSet[0], CoderInterface::CHECKSUM_ALGORITHM],
+            'wrong checksum' => ['?' . $dataSet[1], CoderInterface::CHECKSUM_ALGORITHM],
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -49,9 +49,12 @@ public function testChecksumThrows(string $data, string $algorithm): void`
`49`	`49`
`50`	`50`	`public static function dataChecksumThrows(): array`
`51`	`51`	`{`
	`52`	`+ $dataSet = self::dataChecksum()[CoderInterface::CHECKSUM_ALGORITHM];`
`52`	`53`	`return [`
`53`		`- 'wrong algorithm' => ['', '?'],`
`54`		`- 'wrong checksum' => ['?', CoderInterface::CHECKSUM_ALGORITHM],`
	`54`	`+ 'wrong algorithm' => [$dataSet[1], '?'],`
	`55`	`+ 'short data' => ['?', CoderInterface::CHECKSUM_ALGORITHM],`
	`56`	`+ 'wrong data' => [$dataSet[0], CoderInterface::CHECKSUM_ALGORITHM],`
	`57`	`+ 'wrong checksum' => ['?' . $dataSet[1], CoderInterface::CHECKSUM_ALGORITHM],`
`55`	`58`	`];`
`56`	`59`	`}`
`57`	`60`