Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unitless line-height and Fontsizes in rem #2

Open
7samurai opened this issue Aug 5, 2019 · 1 comment
Open

Unitless line-height and Fontsizes in rem #2

7samurai opened this issue Aug 5, 2019 · 1 comment

Comments

@7samurai
Copy link

7samurai commented Aug 5, 2019

Hi, first at all: awesome work.

Now some questions: What about some tweaks, maybe whit the chance to change it as an user.
#1 Unitless line-height -> If the font changes, its better to habe these unitless, formular: line-height/font-size:
line-height: 32px;
font-size: 27px;
results in
line-height: 1.185185185;

#2 Let the User define an basis font size (for Example 16px), an give back units in em or better (in my opinion) rem
formular: font-size / base-size -> 27px / 16px = 1.6875rem

@7samurai 7samurai changed the title Unitless LineHeight and Fontsizes in rem Unitless line-height and Fontsizes in rem Aug 5, 2019
@aprinciple
Copy link

+1, add support for line-hieght

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants