Merge pull request DesignPatternsPHP#280 from vuurball/master

Specification pattern - performance optimization

Author: Dominik Liebler

Behavioral/Specification/AndSpecification.php

@@ -17,14 +17,17 @@ public function __construct(SpecificationInterface ...$specifications)
         $this->specifications = $specifications;
     }
 
+    /**
+     * if at least one specification is false, return false, else return true.
+     */
     public function isSatisfiedBy(Item $item): bool
     {
-        $satisfied = [];
-
         foreach ($this->specifications as $specification) {
-            $satisfied[] = $specification->isSatisfiedBy($item);
+            if (!$specification->isSatisfiedBy($item)) {
+                return false;
+            }
         }
 
-        return !in_array(false, $satisfied);
+        return true;
     }
 }

Behavioral/Specification/OrSpecification.php

@@ -17,14 +17,16 @@ public function __construct(SpecificationInterface ...$specifications)
         $this->specifications = $specifications;
     }
 
+    /**
+     * if at least one specification is true, return true, else return false
+     */
     public function isSatisfiedBy(Item $item): bool
     {
-        $satisfied = [];
-
         foreach ($this->specifications as $specification) {
-            $satisfied[] = $specification->isSatisfiedBy($item);
+            if ($specification->isSatisfiedBy($item)) {
+                return true;
+            }
         }
-
-        return in_array(true, $satisfied);
+        return false;
     }
 }