PHP7 Proxy

Author: Dominik Liebler

Structural/Proxy/Record.php

@@ -3,7 +3,7 @@
 namespace DesignPatterns\Structural\Proxy;
 
 /**
- * class Record.
+ * @property string username
  */
 class Record
 {
@@ -21,31 +21,20 @@ public function __construct(array $data = [])
     }
 
     /**
-     * magic setter
-     *
      * @param string $name
-     * @param mixed  $value
-     *
-     * @return void
+     * @param string  $value
      */
     public function __set(string $name, string $value)
     {
         $this->data[$name] = $value;
     }
 
-    /**
-     * magic getter
-     *
-     * @param string $name
-     *
-     * @return string|null
-     */
     public function __get(string $name): string
     {
-        if (isset($this->data[$name])) {
-            return $this->data[$name];
-        } else {
-            return null;
+        if (!isset($this->data[$name])) {
+            throw new \OutOfRangeException('Invalid name given');
         }
+
+        return $this->data[$name];
     }
 }

Structural/Proxy/RecordProxy.php

@@ -32,8 +32,6 @@ public function __construct(array $data)
     }
 
     /**
-     * magic setter
-     *
      * @param string $name
      * @param string  $value
      */
@@ -44,9 +42,6 @@ public function __set(string $name, string $value)
         parent::__set($name, $value);
     }
 
-    /**
-     * @return bool
-     */
     public function isDirty(): bool
     {
         return $this->isDirty;

Structural/Proxy/Tests/ProxyTest.php

@@ -10,15 +10,15 @@ class ProxyTest extends \PHPUnit_Framework_TestCase
     public function testWillSetDirtyFlagInProxy()
     {
         $recordProxy = new RecordProxy([]);
-        $recordProxy->foobar = 'baz';
+        $recordProxy->username = 'baz';
 
         $this->assertTrue($recordProxy->isDirty());
     }
 
     public function testProxyIsInstanceOfRecord()
     {
         $recordProxy = new RecordProxy([]);
-        $recordProxy->foobar = 'baz';
+        $recordProxy->username = 'baz';
 
         $this->assertInstanceOf('DesignPatterns\Structural\Proxy\Record', $recordProxy);
     }