build error using scons on gcc 4.8.4

[jadamcrain]

By default scons, has -Werror=clobbered set in build and GCC 4.8.4 produces a warning for this that gets promoted to error.

It seems we can either resolve the warning or loosen the build flag.

build/opt/src/backends/regex.c: In function 'run_trace':
build/opt/src/backends/regex.c:209:75: error: argument 'trace' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
 HParseResult *run_trace(HAllocator *mm__, HRVMProg *orig_prog, HRVMTrace *trace, const uint8_t *input, int len) {

[jadamcrain]

Hammer uses different flags for debug vs release. This does not break the build when using --variant=debug.

[pesco]

Hm, doesn't appear for me with GCC 4.2.1 or 4.9.3, and also not for Travis-CI with GCC 4.6.3. (The bindings builds run with variant opt.)

I also don't see how that argument could get clobbered, since it's never assigned.

Could it be a fluke/bug in/around that version of GCC...?

[jadamcrain]

Could be. I'll try upgrading to GCC 4.9.3 and see what happens.

[maaronking]

Just to corroborate the behavior stated in @jadamcrain 's original post, I am seeing the same behavior using gcc 4.8.4 on ubuntu 14.04. Indeed the build succeeds when using the --variant=debug flag.