Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct handling of resources relative to the OPENRAVE_DATA path #310

Open
cdellin opened this issue May 24, 2016 · 0 comments
Open

Correct handling of resources relative to the OPENRAVE_DATA path #310

cdellin opened this issue May 24, 2016 · 0 comments

Comments

@cdellin
Copy link
Contributor

cdellin commented May 24, 2016

It has come to my attention that some of our JSON infrastructure does not correctly name resources relative to the OPENRAVE_DATA path (these files exist in the pr_ordata package, so this is the correct way to reference them). Nobody should be passing around OPENRAVE_DATA paths explicitly -- it is up to packages to advertise their ordata/data directories correctly (which pr_ordata does, with the help of openrave_catkin).

According to @mkoval, there are two types of problems:

  1. JSON files are not loaded relative to the OPENRAVE_DATA path. When a JSON file is to be loaded, its actual filesystem path should be resolved using openravepy.RaveFindLocalFile() (like all other such resources are loaded).
  2. The JSON files themselves reference other files with hardcoded paths, instead of paths relative to OPENRAVE_DATA.

I'm also tagging @Shushman and @jeking04 because they were discussing this briefly today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants